desktop
desktop copied to clipboard
remove some frames in group of settings to simplify layouts
on Windows
Windows native widget style
before
regarding design feedback, I am unsure who I should put as reviewers I am now testing on Linux KDE Plasma desktop will ask Camila or Claudio for macOS feedback I am waiting for feedback before making changes in all settings pages (or not)
on KDE Plasma 6 with default theme
I am wondering if we have a way to let the section titles be identified more easily I am really unsure
last state on Windows
last state
hopefully better
dark mode
the label with the desktop client name and release is now left aligned as it should have been so please ignore this in the screenshots
On macOS the result is less positive
After changes:
Before changes:
updated windows screenshots
TO add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned
To add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned
Totally agree, also generally design-wise they look a bit lost when centered, best to keep them left-aligned in any case.
AppImage file: nextcloud-PR-7051-7e8e6ac48aa1d2deb5bffc17186c5986bc40f8b6-x86_64.AppImage
To test this change/fix you can simply download above AppImage file and test it.
Please make sure to quit your existing Nextcloud app and backup your data.
Quality Gate failed
Failed conditions
C Maintainability Rating on New Code (required ≥ A)
1 New Code Smells (required ≤ 0)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
too much issues in this PR not sure what to do maybe close and start again from scratch
@mgallien yes, let’s always do things step by step. Is there any follow-up to this already?