desktop icon indicating copy to clipboard operation
desktop copied to clipboard

remove some frames in group of settings to simplify layouts

Open mgallien opened this issue 1 year ago • 11 comments

on Windows Windows native widget style before image

mgallien avatar Aug 28 '24 13:08 mgallien

regarding design feedback, I am unsure who I should put as reviewers I am now testing on Linux KDE Plasma desktop will ask Camila or Claudio for macOS feedback I am waiting for feedback before making changes in all settings pages (or not)

mgallien avatar Aug 28 '24 13:08 mgallien

on KDE Plasma 6 with default theme image

I am wondering if we have a way to let the section titles be identified more easily I am really unsure

mgallien avatar Aug 28 '24 13:08 mgallien

last state on Windows Screenshot 2024-08-28 171954

mgallien avatar Aug 28 '24 15:08 mgallien

last state hopefully better Screenshot 2024-08-28 220920 Screenshot 2024-08-28 220811

dark mode Screenshot 2024-08-28 221037 Screenshot 2024-08-28 221021

mgallien avatar Aug 28 '24 20:08 mgallien

the label with the desktop client name and release is now left aligned as it should have been so please ignore this in the screenshots

mgallien avatar Aug 28 '24 20:08 mgallien

On macOS the result is less positive

After changes: Screenshot 2024-08-29 at 13 40 21

Before changes: Screenshot 2024-08-29 at 13 40 40

claucambra avatar Aug 29 '24 05:08 claucambra

updated windows screenshots Screenshot 2024-08-29 114455 Screenshot 2024-08-29 114245 Screenshot 2024-08-29 114217

mgallien avatar Aug 29 '24 09:08 mgallien

TO add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned

AndyScherzinger avatar Aug 29 '24 17:08 AndyScherzinger

To add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned

Totally agree, also generally design-wise they look a bit lost when centered, best to keep them left-aligned in any case.

jancborchardt avatar Aug 29 '24 20:08 jancborchardt

AppImage file: nextcloud-PR-7051-7e8e6ac48aa1d2deb5bffc17186c5986bc40f8b6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Sep 15 '24 15:09 nextcloud-desktop-bot

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Sep 15 '24 16:09 sonarqubecloud[bot]

too much issues in this PR not sure what to do maybe close and start again from scratch

mgallien avatar Nov 29 '24 08:11 mgallien

@mgallien yes, let’s always do things step by step. Is there any follow-up to this already?

jancborchardt avatar Dec 09 '24 12:12 jancborchardt