desktop
desktop copied to clipboard
nextcloud
[Bug]: Windows Explorer Shortcuts do not show instance name or URL anymore
⚠️ Before submitting, please verify the following: ⚠️
- [X] This is a bug, not a question or a configuration issue.
- [X] This issue is not already reported on Github (I've searched it).
- [X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
- [X] I agree to follow Nextcloud's Code of Conduct
Bug description
Windows Explorer Shortcuts do not show instance name or URL anymore.
Before Update 3.13.3 the shortcuts were named:
Nextcloud - <Name>
Steps to reproduce
- Install Desktop-Client 3.13.3 on windows
- Add two or more Nextcloud accounts
Expected behavior
Show instance name or url to distinguish different Nextcloud accounts.
Which files are affected by this bug
Operating system
Windows
Which version of the operating system you are running.
Windows 11 Pro 23H2 Build 22631.3880
Package
Official Windows MSI
Nextcloud Server version
28 and 29
Nextcloud Desktop Client version
3.13.3
Is this bug present after an update or on a fresh install?
Updated from a minor version (ex. 3.4.2 to 3.4.4)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
Are you using an external user-backend?
- [X] Default internal user-backend
- [ ] LDAP/ Active Directory
- [ ] SSO - SAML
- [ ] Other
Nextcloud Server logs
No response
Additional info
No response
Possible commit responsible for this: https://github.com/nextcloud/desktop/commit/dbad78c5ebcf3c9a5b9387e87a4cd3bd197e0acb
By the way, it would be great to have some options in the configuration to customize the names of the folders
Hi
Possible commit responsible for this: dbad78c
This commit should display the account name in the explorer, important when you have multiple accounts (as it was before ... with Windows 10 and an old version of the client)
But it doesn't display anything more in the explorer:
@camilasan As you did the changes that are causing this issue I'd like to ask you what were your reasons for this changes? With multiple Nextcloud accounts on multiple nextcloud instances I click around in file explorer everyday until I find the right folder.
I don't want to just create a PR reverting your changes and undoing work you've done. But the current situation does not work well for me either.
With the versions 3.16.4 and 3.16.6 the problem exists again.
That was noted and I am working on it.
It is fixed, but was not included in a release yet
from my tests, https://github.com/nextcloud/desktop/pull/8135 is not fixing it.
See: #8135
@SnejPro if you run master now on Windows 10/11, do you see the 'url - user' in shortcuts?
When I checkout the 3.16.6 source code, I don't see the changes I've made. In master I see them.
My last build with master is two months old and it worked back then. I haven't checked it again.
The new scheme only applies if you have two or more nextcloud accounts.
something might have changed after https://github.com/nextcloud/desktop/pull/8135 that broke it. I am trying to figure it out...
something might have changed after https://github.com/nextcloud/desktop/pull/8135 that broke it. I am trying to figure it out...
It's also possible that there was something different with my development setup than yours. It was my first time developing with C and I had a few difficultlies with creating a build environment.
@camilasan I've built nextcloud-desktop again from current master and the shortcuts are named as they should be:
With two accounts:
With one account:
But i noticed one thing: If you add a second folder sync within one account nextcloud-client should generate a second shortcut. But how should this be named?
HI You don't have the Nextcloud icons for shortcuts? For me, the simplest would be to let the user choose to name his shortcuts (settings in the GUI window)
Hi,
You don't have the Nextcloud icons for shortcuts?
This is only a limitation of my build environment (I think).
For me, the simplest would be to let the user choose to name his shortcuts (settings in the GUI window)
Yes, this would be a cool feature. But even with that, you need a default behavior. I'd love to implement this, but unfortunaly I have almost no experience in developing desktop applications and developing in C++ and no time to learn these things.
Greetings
Jens
If you add a second folder sync within one account nextcloud-client should generate a second shortcut. But how should this be named?
the name of the folder
I've built nextcloud-desktop again from current master and the shortcuts are named as they should be:
If you do a clean install with one of the daylies, maybe with a test user, your changes still work?
I've built nextcloud-desktop again from current master and the shortcuts are named as they should be:
If you do a clean install with one of the daylies, maybe with a test user, your changes still work?
I've installed the daily, created a new windows user and connected to two nextcloud accounts. It works. But it does not work when virtual files are enabled. Personally, I do not use this feature, so I did not notice it.
@camilasan There it is: https://github.com/SnejPro/nc-desktop/blob/a21432982312a5031695a998e953142a78779c46/src/gui/folder.cpp#L519
I've installed the daily, created a new windows user and connected to two nextcloud accounts. It works. But it does not work when virtual files are enabled. Personally, I do not use this feature, so I did not notice it.
On Windows 10 or 11?
Hi @camilasan ,
thanks for fixing the issues and including it in the current release. It really helps a lot.
But I have an suggestion: Shouldn't we hide the "Nextcloud - "-Part when displaying more than one instances. In my view it is an unnessecary information, especially because there already is the nextcloud icon:
Greetings,
Jens