desktop icon indicating copy to clipboard operation
desktop copied to clipboard

[Bug]: Various shades of grey in darkmode

Open AndyScherzinger opened this issue 1 year ago • 9 comments

Might be on purpose, hence close if n/a

Sync tab Connection settings tab Settings win11 settings example
2024-08-27 17_01_54-NVIDIA GeForce Overlay 2024-08-27 17_02_04-NVIDIA GeForce Overlay 2024-08-27 17_02_25-Nextcloud-Einstellungen 2024-08-27 17_00_59-Einstellungen
  • various grey tones for the main content area
  • slightly different size/color on checkboyes and radio buttons

AndyScherzinger avatar Aug 27 '24 15:08 AndyScherzinger

main dialog screenshot using more native styling with dark mode (Fusion qml style) image

set status image

this was done by using https://github.com/nextcloud/desktop/pull/6980 there is an issue with the Windows native QML style this style should look more native but is not working with dark mode I tried to fix this but that may be a lot of work

mgallien avatar Aug 28 '24 08:08 mgallien

I realized that current builds on Windows use "fusion" widget style for QWidget based dialogs with native style, I think we are already better image

please note that there is a double frame around the folder configuration area

mgallien avatar Aug 28 '24 08:08 mgallien

with better native style on Windows and a couple more small improvements image image image

mgallien avatar Aug 28 '24 09:08 mgallien

Nice improvements @mgallien 🤩

AndyScherzinger avatar Aug 28 '24 09:08 AndyScherzinger

I am unsure what to do with the QML user interfaces should we stay with Fusion non native but looking good in bright and dark mode ? should we go with native Windows style and spend a big effort trying to make it work in dark mode ?

I can provide bright mode screenshots to help

@AndyScherzinger @jancborchardt

mgallien avatar Aug 28 '24 09:08 mgallien

Fusion bright mode image

Windows bright mode image

mgallien avatar Aug 28 '24 10:08 mgallien

@mgallien we should always prefer to have it as native as possible on all platforms. In the 2 screenshots, besides some bugs in the Windows version that have to be fixed, there is almost no discernible difference, and both can look more native.

Another example in settings, the tabs don’t look like standard (more like 2 buttons?) and the line containers for settings groups look quite dated: image

jancborchardt avatar Aug 28 '24 10:08 jancborchardt

I will (but in the make UI more native PR) record a video. I would ping design team there. That should make differences more obvious.

Regarding the frames in the settings dialog, I need to investigate why they look so bad by default. I do not think we override or customize anything there.

mgallien avatar Aug 28 '24 10:08 mgallien

regarding the frames and generally the settings please have a look at the screenshots in https://github.com/nextcloud/desktop/pull/7051 I just forgot to left align a single label and fixed after the screenshots

mgallien avatar Aug 28 '24 20:08 mgallien

These theming issues should now been fixed

claucambra avatar Jan 23 '25 02:01 claucambra