nextcloud
Add tag support in sync process
I added basic support for file tags to the desktop client. Actually it is a draft, as long as also some of my todos also are already open. But I am welcome for early feedback about the integration.
So finally this shall fix #206
On client side, everything should be done for Mac and Linux. Tags will be synced, as good as possible with current server side implementation. For the following points a change on server side is also necessary:
- Full down sync of server side tag changes. Currently the client is not informed, if a tag to file is changed on the server side. Probably this could be done, by finally implementing the metadata_etag property to inform the client about that. Actually the synchronisation is done by coincidence or if the file was changed.
- Full up sync is not possible, because system tags cannot updated via PROPPATCH. We actually safe client side tags via the oc:tags property. Later, if also system tags can be updated via PROPPATCH it should automatically handle tags as system tags, if present and as oc:tags, if not as system tag present. That means actually in practice: system-tags cannot be changed on client side. They will be overridden with the server side data frequently. Client side assigned tags which are no system tags are fully synchronised.
Following client side improvements cloud be done in the future:
- implementation in windows client. Maybe the IPropertySet is the right way, but I have to investigate a bit more.. So that this could be a new pull request and finish this one as soon as possible.
@tobiasKaminsky @mgallien are you aware of this nice pull request? :)
@joecomo67
this sounds great - is there a way to use this already?
Actually I am awaiting review from the nextcloud staff. I don't know their priorities, so I have to wait.
Even if I am confident, that the pull request will solve the issue, I recommend to wait for their review, because I am not so deep into the nexcloud logic then they will be.
H, thanks for replay. I will work on that soon. Unfortunately I have much to do at work, so I will need some time.