desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Support the KF6 based version of Dolphin

Open er-vin opened this issue 1 year ago • 4 comments

This is not a Qt6 port of the whole client. Still, KF6 based Dolphin is around the corner so make sure it will still benefit from the shell integration plugin.

This PR does some stylistic changes and cleanups to the code but this is mainly here to help the transition to the Qt6/KF6 build which seems a bit stricter by default than older versions.

The real important part of the work is the CMake adjustments and trying to detect both KF5 and KF6 KIO versions to figure out what's around.

Important: My current setup doesn't make it easy to test Qt5 and Qt6 based builds in parallel. So some more extensive testing from someone with a more traditional setup is likely welcome.

er-vin avatar Dec 27 '23 18:12 er-vin

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 27 '23 18:12 sonarqubecloud[bot]

Do we agree that the clang-tidy, windows and mac build are false positives? If someone confirms I'll go ahead, ignoring them, and merging this PR.

er-vin avatar Feb 18 '24 11:02 er-vin

Do we agree that the clang-tidy, windows and mac build are false positives? If someone confirms I'll go ahead, ignoring them, and merging this PR.

yes they are false positive I am sorry as I am missing time to more quickly fix them (at least the windows one) I have hopes to be able to fix the windows one this week

mgallien avatar Mar 06 '24 13:03 mgallien

AppImage file: nextcloud-PR-6320-38b59a82bf8a4f6007f1eac2906ae3957e46eba7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Mar 06 '24 14:03 nextcloud-desktop-bot

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 06 '24 14:03 sonarqubecloud[bot]

Hi,

I'm a KDE Neon User, I use de the release 3.13.0 of dolphin-nextcloud (installed with Nextcloud PPA) that should work properly with Plasma 6 (QT6/KF6), but I still don't have the sync indicators on files and no context menu in Dolphin (cf. my downstream ticket: https://bugs.kde.org/show_bug.cgi?id=483423#c2).

Am I the only one?

Beurt avatar May 19 '24 17:05 Beurt