[Bug]: Fulltext search result links are wrong

[arnowelzel]

⚠️ Before submitting, please verify the following: ⚠️

• [X] This is a bug, not a question or a configuration issue.
• [X] This issue is not already reported on Github (I've searched it).
• [X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• [X] I agree to follow Nextcloud's Code of Conduct

Bug description

When doing a fulltext search in the client, the links to documents are generated like this:

https://server.example/apps/files/%3Fdir=/some/folder/&scrollto=somefile.pdf

However, the escaping "%3F" is wrong. This must be "?":

https://server.example/apps/files/?dir=/some/folder/&scrollto=somefile.pdf

Steps to reproduce

1. Search for a file with the Nextcloud desktop client
2. Click on one of the found files within the "Full Text Search" result
3. See the link in the browser which contains "%3F" instead of "?"

Expected behavior

The result link contains "/apps/files?dir=" and not "/apps/files%3Fdir=".

Which files are affected by this bug

not relevant, affects every search result

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Appimage

Nextcloud Server version

27.1.2, 27.1.3, 28.0.0, 28.0.1

Nextcloud Desktop Client version

3.10.0, 3.10.1, 3.11.0

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

• [X] Default internal user-backend
• [ ] LDAP/ Active Directory
• [ ] SSO - SAML
• [ ] Other

Nextcloud Server logs

No response

Additional info

No response

[hyperlink-skylight]

We encounter the exact same issue as we want to enable full text search.

It is still present with this versions:

Nextcloud Server version: 27.1.10 Nextcloud Desktop Client version: Windows 3.13.0 Full text search: 27.0.3 Full text search - Elasticsearch Platform: 27.0.6 Full text search - Files: 27.0.1 Full text search - Files - Tesseract OCR: 27.0.0

But the Tesseract OCR app should not make any difference. I have testet it with and without it and it was reproducable.

Here is the bug archive of the client: fulltextsearch_bug.zip

In this case, I searched for "fullindexsearchexcel". (Hope that helps)

Or is this more related to the fulltextsearch app? Then I would create an issue there, too.

[SonicBlitz]

Same issue here

Server Version: Nextcloud 30.0.5 Desktop Client: 3.15.2 Fulltextsearch: 30.0.0 (Files, Elasticsearch)

[Rello]

Hello,

the client was enhanced significantly since the opening of this ticket. If you are still encountering issues, please get back to us. I just tried it and it works as expected

[arnowelzel]

Thanks for the feedback. But it would be even more helpful if anyone could tell, what exactly was changed to address this issue. Otherwise the same problem may appear again in the future if nobody really fixed the root ccause but it just works somehow now and next time when the code gets changed, it fails again.

[Rello]

Hallo @arnowelzel while I understand your request, we can not map every 2 year issue here against the 1000s of commits that were implemented in the meantime. Same as we support you with triaging and fixing issues, we also depend on the community to retest and confirm them

[arnowelzel]

@Rello Ok, then I will test and see. And if it one time fails again, I have to wait another 1-2 years to get it fixed because nobody knows what caused the problem in the first place? ;-)