adds ability to specify user and password via env variables

[internet-memme]

Proposal for issue #5875

It adds the ability to specify username and password in '--non-interactive' via $NC_USER and $NC_PASSWORD. This is the last option in the chain of username/password lookups. It also updates the documentation accordingly.

[internet-memme]

ok I think the merge should be reverted

[claucambra]

ok I think the merge should be reverted

I still see several merge commits

[internet-memme]

I am not quite sure what I am supposed to do. Which commits exactly should I (revert?).

[claucambra]

I am not quite sure what I am supposed to do. Which commits exactly should I (revert?).

You should do an interactive rebase on master and drop the following commits:

• d8549cb46d5bfb4f626006af65fd42c71596c495
• def7b65d122f93d58d1f41268247d2de8206f27f
• 8c222eef476a8b4492ff7b45044aad0602d8cd09
• e2e3c92bc3fa9a9a4e9b0fec6954f4aec7e418e7

You should also squash the remaining commits

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5980-240c0ce7c297cd4c1e4ebf6d0a7f0365f50a33c4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[internet-memme]

Oh thank you for doing the rebase :)

[codecov[bot]]

Codecov Report

Merging #5980 (2f7d468) into master (e30decc) will decrease coverage by 0.42%. Report is 37 commits behind head on master. The diff coverage is n/a.

:exclamation: Current head 2f7d468 differs from pull request most recent head d3e7ed7. Consider uploading reports for the commit d3e7ed7 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5980      +/-   ##
==========================================
- Coverage   60.74%   60.32%   -0.42%     
==========================================
  Files         145      145              
  Lines       18841    18800      -41     
==========================================
- Hits        11445    11342     -103     
- Misses       7396     7458      +62     

see 28 files with indirect coverage changes

[joshtrichards]

I suggest we set DCO to pass on this one - it's only failing on the @claucambra's revert merge branch single commit - unless someone has an objection.

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5980-d3e7ed7391c0a4431e036bb598a2a13c06107c2b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

@internet-memme sorry for the long delay are you still interested in getting this PR merged ? could you rebase and fix conflicts ?

[camilasan]

I am sorry for the delay on this. I created this PR #8490 to be able to merge your work. Thank you @internet-memme!