desktop
desktop copied to clipboard
nextcloud
Big sur icon annotations
This is a redux of https://github.com/nextcloud/desktop/pull/4714 because of issues identified in https://github.com/nextcloud/desktop/pull/5757.
@claucambra—could you elaborate on the how the previous version of this broke the app icon, so I can fix it? Thanks!
(I wasn't sure how to reopen a merged pull request, so I may have done this incorrectly.)
AppImage file: nextcloud-PR-5793-7580ba86a00a70ef7ff6b8fa56d3278c5c4df9a6-x86_64.AppImage
To test this change/fix you can simply download above AppImage file and test it.
Please make sure to quit your existing Nextcloud app and backup your data.
Codecov Report
Merging #5793 (7580ba8) into master (ec7fd95) will increase coverage by
2.51%. The diff coverage is48.19%.
Additional details and impacted files
@@ Coverage Diff @@
## master #5793 +/- ##
==========================================
+ Coverage 57.83% 60.34% +2.51%
==========================================
Files 141 143 +2
Lines 18143 18530 +387
==========================================
+ Hits 10493 11182 +689
+ Misses 7650 7348 -302
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/common/filesystembase.cpp | 76.43% <ø> (ø) |
|
| src/common/ownsql.cpp | 66.93% <ø> (+0.40%) |
:arrow_up: |
| src/common/ownsql.h | 81.25% <ø> (-18.75%) |
:arrow_down: |
| src/common/syncjournaldb.h | 75.00% <ø> (ø) |
|
| src/common/syncjournalfilerecord.h | 54.54% <0.00%> (-5.46%) |
:arrow_down: |
| src/csync/csync.h | 75.00% <ø> (ø) |
|
| src/csync/vio/csync_vio_local_win.cpp | 81.39% <ø> (ø) |
|
| src/libsync/account.h | 40.00% <ø> (+3.15%) |
:arrow_up: |
| src/libsync/bulkpropagatorjob.cpp | 74.71% <ø> (+1.53%) |
:arrow_up: |
| src/libsync/bulkpropagatorjob.h | 50.00% <ø> (ø) |
|
| ... and 40 more |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Kudos, SonarCloud Quality Gate passed!  
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @elsiehupp sorry for the late reply
We had a major issue as after the icon generation in the initial build step (using inkscape), we would just get a completely black icon for the app; we didn't have this issue without the annotations. Are you able to reproduce this?
No worries about the late reply (I say like three months later lol)
What are the steps for running the Inkscape build? Last I checked the CI build process wasn't included in the main repository, so unless I'm missing something, could you point me in the direction of where to look? (Also last I checked the local build process was broken on macOS, so I wouldn't even know where to start at this point.)