desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Streamline logger creation of next log files

Open claucambra opened this issue 2 years ago • 4 comments

By eliminating certain parts of the process of creating new log files, such as redundant searching for legacy client log files and regex matching, stepping into new log files should be a bit faster

claucambra avatar May 21 '23 16:05 claucambra

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 60.37%. Comparing base (cf68901) to head (dbebdae). Report is 2965 commits behind head on master.

Files with missing lines Patch % Lines
src/libsync/logger.cpp 0.00% 26 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5721      +/-   ##
==========================================
+ Coverage   60.26%   60.37%   +0.11%     
==========================================
  Files         143      143              
  Lines       18518    18526       +8     
==========================================
+ Hits        11159    11185      +26     
+ Misses       7359     7341      -18     
Files with missing lines Coverage Δ
src/libsync/logger.h 61.53% <100.00%> (ø)
src/libsync/logger.cpp 29.21% <0.00%> (+0.64%) :arrow_up:

... and 18 files with indirect coverage changes

codecov[bot] avatar May 21 '23 16:05 codecov[bot]

/backport to stable-3.9

claucambra avatar May 22 '23 08:05 claucambra

AppImage file: nextcloud-PR-5721-dbebdae2d098a530c2eb85a451e601e91ca6e400-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Jun 08 '23 09:06 nextcloud-desktop-bot