Use AccountPtr in Account signals instead of raw pointer
TestPushNotificationstest is failing for me can you investigate ?
Now fixed
Codecov Report
Merging #5543 (6146f02) into master (54a11e8) will decrease coverage by
0.08%. The diff coverage is14.28%.
Additional details and impacted files
@@ Coverage Diff @@
## master #5543 +/- ##
==========================================
- Coverage 58.96% 58.88% -0.08%
==========================================
Files 143 143
Lines 18314 18332 +18
==========================================
- Hits 10798 10795 -3
- Misses 7516 7537 +21
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/libsync/account.h | 36.84% <ø> (ø) |
|
| src/libsync/creds/httpcredentials.cpp | 6.87% <0.00%> (-0.02%) |
:arrow_down: |
| src/libsync/account.cpp | 35.85% <16.66%> (ø) |
Quality Gate failed
Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
61 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
AppImage file: nextcloud-PR-5543-7bdd45314d7c866bee49e0f5969afe926d7eb0d7-x86_64.AppImage
To test this change/fix you can simply download above AppImage file and test it.
Please make sure to quit your existing Nextcloud app and backup your data.
Quality Gate failed
Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
76 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
/backport to stable-3.16
Artifact containing the AppImage: nextcloud-appimage-pr-5543.zip
SHA256 checksum: dac9c3fa385b12410fb663fe1adcc86a0b3ca66e7dbe453e202c986067498f7f
To test this change/fix you can download the above artifact file, unzip it, and run it.
Please make sure to quit your existing Nextcloud app and backup your data.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code







