desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Use AccountPtr in Account signals instead of raw pointer

Open claucambra opened this issue 2 years ago • 5 comments

claucambra avatar Mar 22 '23 14:03 claucambra

TestPushNotifications test is failing for me can you investigate ?

Now fixed

claucambra avatar Mar 23 '23 16:03 claucambra

Codecov Report

Merging #5543 (6146f02) into master (54a11e8) will decrease coverage by 0.08%. The diff coverage is 14.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
- Coverage   58.96%   58.88%   -0.08%     
==========================================
  Files         143      143              
  Lines       18314    18332      +18     
==========================================
- Hits        10798    10795       -3     
- Misses       7516     7537      +21     
Impacted Files Coverage Δ
src/libsync/account.h 36.84% <ø> (ø)
src/libsync/creds/httpcredentials.cpp 6.87% <0.00%> (-0.02%) :arrow_down:
src/libsync/account.cpp 35.85% <16.66%> (ø)

... and 5 files with indirect coverage changes

codecov[bot] avatar Mar 23 '23 17:03 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
61 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Oct 18 '24 07:10 sonarqubecloud[bot]

AppImage file: nextcloud-PR-5543-7bdd45314d7c866bee49e0f5969afe926d7eb0d7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Nov 20 '24 07:11 nextcloud-desktop-bot

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
76 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud[bot] avatar Nov 20 '24 07:11 sonarqubecloud[bot]

/backport to stable-3.16

claucambra avatar Apr 15 '25 09:04 claucambra

Artifact containing the AppImage: nextcloud-appimage-pr-5543.zip

SHA256 checksum: dac9c3fa385b12410fb663fe1adcc86a0b3ca66e7dbe453e202c986067498f7f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

github-actions[bot] avatar Apr 15 '25 09:04 github-actions[bot]