Swap unhelpful trailing slash asserts in syncfilestatustracker for useful sanitised paths instead

[claucambra]

This actually helps the SyncFileStatusTracker do its job rather than just throw an error

Signed-off-by: Claudio Cambra [email protected]

[codecov[bot]]

Codecov Report

Merging #5306 (2240c7b) into master (2e0680e) will decrease coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 2240c7b differs from pull request most recent head 14c5e46. Consider uploading reports for the commit 14c5e46 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
- Coverage   57.60%   57.59%   -0.02%     
==========================================
  Files         139      139              
  Lines       17631    17633       +2     
==========================================
- Hits        10157    10156       -1     
- Misses       7474     7477       +3     

Impacted Files	Coverage Δ
src/libsync/syncfilestatustracker.cpp	93.33% <100.00%> (+0.08%)	:arrow_up:
src/libsync/discovery.cpp	85.93% <0.00%> (-0.29%)	:arrow_down:

[claucambra]

can you make sure this is also covered by automated tests ?

tests pass :)

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5306-14c5e469fc028eb625beb8160a154998fa1c7d91-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

@claucambra can you fix the conflict ?

[mgallien]

closing it there are conflicts and I still think it is doing too many things in release builds