Since NavigationPaneHelper only includes functionality relevant to Windows and its introduction causes compile warnings on other platforms, this PR excludes the NPH from non-Windows builds

The ifdefs that cause warnings on other platforms have been modified to fix them if in the future NavigationPaneHelper is used on other platforms too

Dec 19 '22 16:12 claucambra

Codecov Report

Merging #5288 (59940f6) into master (fb83518) will decrease coverage by 0.03%. The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5288      +/-   ##
==========================================
- Coverage   57.63%   57.59%   -0.04%     
==========================================
  Files         139      139              
  Lines       17596    17596              
==========================================
- Hits        10142    10135       -7     
- Misses       7454     7461       +7

Impacted Files	Coverage Δ
src/libsync/propagatedownload.cpp	`63.72% <0.00%> (-1.18%)`	:arrow_down:
src/libsync/propagateremotemove.cpp	`82.28% <0.00%> (+0.57%)`	:arrow_up:

Dec 19 '22 16:12 codecov[bot]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Dec 19 '22 18:12 sonarqubecloud[bot]

AppImage file: nextcloud-PR-5288-59940f65dbc40f4823c794e096432faea24a451c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Dec 19 '22 22:12 nextcloud-desktop-bot

@claucambra can you fix the conflicts ?

Thanks, done

Mar 13 '25 03:03 claucambra

looks good, but there is also another usage of navigationPaneHelper that breaks compilation:
src/gui/accountsetupfromcommandlinejob.cpp
179:    if (folderMan->navigationPaneHelper().showInExplorerNavigationPane()) {

Thanks, fixed

Mar 14 '25 03:03 claucambra