desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Fix MacOS UTF-8 normalization issue

Open xavi-b opened this issue 3 years ago • 3 comments
trafficstars

Fix https://github.com/nextcloud/desktop/issues/4950

xavi-b avatar Sep 19 '22 22:09 xavi-b

AppImage file: nextcloud-PR-4957-5057fd94ae01fa35e2deb98b2261bd93071719d6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Sep 20 '22 12:09 nextcloud-desktop-bot

Codecov Report

Merging #4957 (5057fd9) into master (38ae92b) will decrease coverage by 2.17%. The diff coverage is 100.00%.

:exclamation: Current head 5057fd9 differs from pull request most recent head 5113802. Consider uploading reports for the commit 5113802 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4957      +/-   ##
==========================================
- Coverage   59.28%   57.12%   -2.17%     
==========================================
  Files         143      138       -5     
  Lines       18445    17234    -1211     
==========================================
- Hits        10936     9845    -1091     
+ Misses       7509     7389     -120     
Impacted Files Coverage Δ
src/common/syncjournaldb.cpp 77.45% <100.00%> (-1.24%) :arrow_down:

... and 78 files with indirect coverage changes

codecov[bot] avatar Sep 20 '22 12:09 codecov[bot]

@xavi-b thanks for your contribution

why do even need to use such a phash column with possibilities for troubles when we can just use the path column ? I would rather remove the use for the phash column rather than trying to make it more robust just in case we can identify some of the problems of using it

mgallien avatar Sep 22 '22 08:09 mgallien

AppImage file: nextcloud-PR-4957-5113802daf38afdf5934fcd210e74513b22decd8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Apr 23 '23 16:04 nextcloud-desktop-bot

/backport to stable-3.8

claucambra avatar Apr 24 '23 03:04 claucambra