desktop icon indicating copy to clipboard operation
desktop copied to clipboard

l10n: Change to a capital letter

Open Valdnet opened this issue 3 years ago • 4 comments

Signed-off-by: Valdnet [email protected]

Valdnet avatar Sep 18 '22 15:09 Valdnet

Codecov Report

Merging #4953 (dba4e18) into master (9f952e3) will increase coverage by 0.13%. The diff coverage is 100.00%.

:exclamation: Current head dba4e18 differs from pull request most recent head 2fe3801. Consider uploading reports for the commit 2fe3801 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
+ Coverage   56.98%   57.12%   +0.13%     
==========================================
  Files         138      138              
  Lines       17232    17232              
==========================================
+ Hits         9819     9843      +24     
+ Misses       7413     7389      -24     
Impacted Files Coverage Δ
src/libsync/owncloudpropagator.cpp 85.88% <100.00%> (ø)
src/libsync/propagatedownload.cpp 64.61% <100.00%> (ø)
src/libsync/propagateremotemove.cpp 82.28% <100.00%> (ø)
src/libsync/propagatorjobs.cpp 73.23% <100.00%> (ø)
src/libsync/syncfileitem.h 37.50% <0.00%> (ø)
src/libsync/bulkpropagatorjob.cpp 73.10% <0.00%> (ø)
src/libsync/progressdispatcher.cpp 51.17% <0.00%> (ø)
src/libsync/syncengine.cpp 85.56% <0.00%> (+0.53%) :arrow_up:
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.42% <0.00%> (+1.82%) :arrow_up:
... and 2 more

codecov[bot] avatar Sep 18 '22 15:09 codecov[bot]

@camilasan Delete a commit and re-add it to the merge?

Valdnet avatar Sep 20 '22 13:09 Valdnet

AppImage file: nextcloud-PR-4953-2fe380174ed6322544ea85809114a41722a90a9a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Sep 27 '22 09:09 nextcloud-desktop-bot

@camilasan Delete a commit and re-add it to the merge?

You seem to have done it right, but now there are 5 commits. Could you squash them? Sorry for the late reply on this.

camilasan avatar Dec 06 '22 09:12 camilasan

Could you squash them?

@camilasan I make changes from the GitHab level and I have no way to squash directly. Can you do this with Git?

Valdnet avatar Dec 07 '22 06:12 Valdnet