desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Ensure that clear status message combo box is at least implicit width

Open claucambra opened this issue 2 years ago • 3 comments

This PR makes sure that the "Clear status message" combo does not get squashed too far. This should help avoid breakage with translations and larger font sizes

Example with fix:

Screenshot_20220810_195502

Master:

imagen

Signed-off-by: Claudio Cambra [email protected]

claucambra avatar Aug 10 '22 18:08 claucambra

Codecov Report

Merging #4844 (b279560) into master (6746717) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b279560 differs from pull request most recent head ecab3d7. Consider uploading reports for the commit ecab3d7 to get more accurate results

@@           Coverage Diff           @@
##           master    #4844   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files         138      138           
  Lines       17144    17144           
=======================================
  Hits         9809     9809           
  Misses       7335     7335           
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (ø)

codecov[bot] avatar Aug 10 '22 18:08 codecov[bot]

AppImage file: Nextcloud-PR-4844-ecab3d76ee927a22d6fe6cc1756c20c42d777d01-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Aug 17 '22 18:08 nextcloud-desktop-bot

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 17 '22 18:08 sonarqubecloud[bot]