Add a ScrollView to the predefined statuses area of the UserStatusSelector

Open claucambra opened this issue 3 years ago • 3 comments

This PR wraps the predefined statuses in a scrollview in cases where there is not enough vertical space to display all the entries.

In most setups there is no change and the predefined statuses appear exactly as they did before:

Screenshot_20220810_174929

But to prevent big breakages on setups with custom font sizing, the predefined statuses become a scrollview:

Screenshot_20220810_174326

This should prevent breakages for users using larger text sizes for display or accessibility reasons

Signed-off-by: Claudio Cambra [email protected]

Aug 10 '22 15:08 claucambra

Codecov Report

Merging #4842 (9417b82) into master (03b259b) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Current head 9417b82 differs from pull request most recent head 2fe4bc5. Consider uploading reports for the commit 2fe4bc5 to get more accurate results

@@            Coverage Diff             @@
##           master    #4842      +/-   ##
==========================================
- Coverage   57.23%   57.20%   -0.03%     
==========================================
  Files         138      138              
  Lines       17146    17144       -2     
==========================================
- Hits         9813     9807       -6     
- Misses       7333     7337       +4

Impacted Files	Coverage Δ
src/libsync/propagateremotemkdir.cpp	`61.70% <0.00%> (-3.55%)`	:arrow_down:
src/libsync/owncloudpropagator.h	`72.51% <0.00%> (-0.77%)`	:arrow_down:
src/libsync/vfs/cfapi/cfapiwrapper.cpp	`74.25% <0.00%> (-0.46%)`	:arrow_down:
src/libsync/bulkpropagatorjob.cpp	`72.14% <0.00%> (-0.16%)`	:arrow_down:
src/libsync/propagatedownload.cpp	`65.33% <0.00%> (+0.14%)`	:arrow_up:
src/libsync/filesystem.cpp	`76.34% <0.00%> (+3.22%)`	:arrow_up:

Aug 10 '22 16:08 codecov[bot]

AppImage file: Nextcloud-PR-4842-0f2fafd950cf26c06005bf5530c7c139dcba51d6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Aug 18 '22 11:08 nextcloud-desktop-bot

@mgallien @camilasan @allexzander I think this should be merged for RC2 as otherwise we risk breaking the user status selector layout for users with unexpected setups (language, font sizes, etc)

Aug 23 '22 21:08 claucambra

Kudos, SonarCloud Quality Gate passed!