Remove Ubuntu Focal

[ivaradi]

As discussed, Focal should be not supported from 3.6 on. Since master has been moved to 3.6.0, this PR removes building for Focal.

[ivaradi]

@camilasan, @allexzander or @mgallien: can I get an approval? And a merging as well, since I cannot merge, if SonarCloud fails? Thanks.

[codecov[bot]]

Codecov Report

Merging #4840 (09b7c64) into master (b245c3d) will decrease coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head 09b7c64 differs from pull request most recent head b0d881e. Consider uploading reports for the commit b0d881e to get more accurate results

@@            Coverage Diff             @@
##           master    #4840      +/-   ##
==========================================
- Coverage   57.23%   57.22%   -0.01%     
==========================================
  Files         138      138              
  Lines       17146    17144       -2     
==========================================
- Hits         9813     9811       -2     
  Misses       7333     7333              

Impacted Files	Coverage Δ
src/libsync/bulkpropagatorjob.cpp	72.14% <0.00%> (-0.16%)	:arrow_down:
src/libsync/propagatedownload.cpp	65.18% <0.00%> (ø)

[jancborchardt]

We already want to remove compatibility for 20.04? The new 22.04 LTS just had its dot release, so shouldn’t we wait a bit more?

[claucambra]

We already want to remove compatibility for 20.04? The new 22.04 LTS just had its dot release, so shouldn’t we wait a bit more?

Our 20.04 package is kept going through a set of fragile patches that break on practically every release. The version of Qt shipped with 20.04 is just ancient, and considering the constant issues we face on this OS I don't think we should keep supporting 20.04. At least, this is the case for the PPA -- the AppImage is always available

[ivaradi]

@claucambra, @camilasan, @allexzander, @mgallien please, review this PR and merge it. Thanks.

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4840-09b7c6458b56b0df34673e7a01b888cd4990bc4d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

@ivaradi sorry for the delay I will keep an eye on it today and make sure we can merge it

[mgallien]

We already want to remove compatibility for 20.04? The new 22.04 LTS just had its dot release, so shouldn’t we wait a bit more?

this is indeed bad but to be able to prepare switching to the current major Qt version we have to use and depend on Qt 5.15 that is not in Ubuntu 20.04

The move to Qt 6 would allow to better support all macOS platforms and generally provide more fixes that we may be missing

That would bring better support for recent versions of Windows and macOS

that would bring better native look for qml controls on windows and macOS

to prepare for the switch many replacement APIs and deprecation notices have been put into Qt 5.15 and Qt 5.15.2 minor release

[jancborchardt]

Sounds good then! And by now the 22.04.1 dot-release is out and everyone still on 20.04 is prompted to update to the new LTS. :)