Use same tooltip component everywhere, fix tooltip clipping bugs

Open claucambra opened this issue 3 years ago • 3 comments

trafficstars

This prevents the need to duplicate our tooltip code (like setting the content item and background) everywhere.

This tangentially also fixes an issue with tooltip text in unified search list items clipping through the tooltip

Signed-off-by: Claudio Cambra [email protected]

Aug 09 '22 15:08 claucambra

Codecov Report

Merging #4833 (9b2936b) into master (eb4e8ad) will decrease coverage by 0.08%. The diff coverage is n/a.

:exclamation: Current head 9b2936b differs from pull request most recent head 5acb0b2. Consider uploading reports for the commit 5acb0b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #4833      +/-   ##
==========================================
- Coverage   57.17%   57.09%   -0.09%     
==========================================
  Files         138      138              
  Lines       17133    17144      +11     
==========================================
- Hits         9796     9788       -8     
- Misses       7337     7356      +19

Impacted Files	Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp	`52.68% <0.00%> (-3.77%)`	:arrow_down:
src/libsync/vfs/cfapi/vfs_cfapi.cpp	`85.09% <0.00%> (-1.33%)`	:arrow_down:
src/libsync/vfs/cfapi/cfapiwrapper.cpp	`72.89% <0.00%> (-1.31%)`	:arrow_down:
src/libsync/syncengine.cpp	`86.67% <0.00%> (-0.55%)`	:arrow_down:
src/libsync/bulkpropagatorjob.cpp	`72.14% <0.00%> (-0.16%)`	:arrow_down:
src/libsync/propagatedownload.cpp	`65.33% <0.00%> (+0.29%)`	:arrow_up:

Aug 09 '22 15:08 codecov[bot]

AppImage file: nextcloud-PR-4833-5acb0b272a6149268cc9e3d0a5816fa38b4499c6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.