desktop
desktop copied to clipboard
Simplify activity list delegates by making them ItemDelegates, clean up
Rather than use a MouseArea and some wacky workarounds to get the sizing we want, the ItemDelegate does exactly what we want to the proper way
Signed-off-by: Claudio Cambra [email protected]
Kudos, SonarCloud Quality Gate passed!  
Codecov Report
Merging #4786 (2028b7e) into master (a40202c) will increase coverage by
0.07%. The diff coverage isn/a.
:exclamation: Current head 2028b7e differs from pull request most recent head 85c5002. Consider uploading reports for the commit 85c5002 to get more accurate results
@@ Coverage Diff @@
## master #4786 +/- ##
==========================================
+ Coverage 57.15% 57.23% +0.07%
==========================================
Files 138 138
Lines 17135 17146 +11
==========================================
+ Hits 9794 9813 +19
+ Misses 7341 7333 -8
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/libsync/owncloudpropagator.h | 73.28% <0.00%> (-1.16%) |
:arrow_down: |
| src/libsync/owncloudpropagator.cpp | 86.00% <0.00%> (-0.03%) |
:arrow_down: |
| src/libsync/syncengine.cpp | 87.22% <0.00%> (+0.02%) |
:arrow_up: |
| src/libsync/propagatedownload.cpp | 65.18% <0.00%> (+0.14%) |
:arrow_up: |
| src/libsync/vfs/cfapi/cfapiwrapper.cpp | 74.71% <0.00%> (+0.51%) |
:arrow_up: |
| src/libsync/propagateremotemkdir.cpp | 65.24% <0.00%> (+0.70%) |
:arrow_up: |
| src/libsync/vfs/cfapi/vfs_cfapi.cpp | 87.45% <0.00%> (+1.03%) |
:arrow_up: |
| src/libsync/propagateuploadng.cpp | 83.89% <0.00%> (+1.49%) |
:arrow_up: |
@claucambra Nice, but, please check my comment.
Kudos, SonarCloud Quality Gate passed!  
AppImage file: nextcloud-PR-4786-85c5002d34f8f41847d9d166c6f3a7c86b8267c9-x86_64.AppImage
To test this change/fix you can simply download above AppImage file and test it.
Please make sure to quit your existing Nextcloud app and backup your data.






