upload the zsync file

[Fuseteam]

i might still need to look into deleting the old zsync file just like it's deleting the old appimage file but otherwise this is ready

[nextcloud-desktop-bot]

AppImage file:

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[Fuseteam]

i don't quite see why it failed

[Thatoo]

It fails because devs didn't yet review it which is the first step.

@FlexW and @mgallien could you review this PR please that would allow to upload the zsync file missing for the AppImage to be able to auto-update .

[mgallien]

@Fuseteam very sorry for the extra delay on our side to get a proper review

thanks for your work

[Fuseteam]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

[Thatoo]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

Yes, you'll have to merge the master branch into your Fuseteam:fix-appimage-update branch. However, don't do it right now as you'll have to do it everytime something change in master till you merge so wait for the review and when the review is ok, you merge master into your branch and then DCO will start again and will be, hopefully, OK.

[mgallien]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

The best is to follow the instructions here

[Fuseteam]

@mgallien is the review ok?

[Fuseteam]

@mgallien the DCO is fine now tho one of the workflow yaml files seems broken, afaik my pr didn't touch it

[Fuseteam]

bah the rebase broke the DCO xd

[Thatoo]

@mgallien could you review please and tell @Fuseteam if something is wrong in his code?

[Fuseteam]

@mgallien are there are blockers left for this PR?

[mgallien]

@mgallien are there are blockers left for this PR?

not sure how to test the upgrade path of an AppImage @Fuseteam do you have pointers to documentation about that ? despite having to work with AppImage, I am still lacking some good docs reference

[mgallien]

@mgallien are there are blockers left for this PR?

DCO is still unhappy see error message

Commit sha: [22bbfef](https://github.com/nextcloud/desktop/pull/4529/commits/22bbfef50d500e4d0a7e885b098144bb41bbeaf2), Author: Rahammetoela Toekiman, Committer: Matthieu Gallien; Expected "Rahammetoela Toekiman [[email protected]](mailto:[email protected])", but got "Fuseteam [[email protected]](mailto:[email protected])".

[codecov[bot]]

Codecov Report

Merging #4529 (a3bab86) into master (10b623e) will decrease coverage by 2.33%. The diff coverage is n/a.

:exclamation: Current head a3bab86 differs from pull request most recent head 8b3539e. Consider uploading reports for the commit 8b3539e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
- Coverage   60.16%   57.83%   -2.33%     
==========================================
  Files         145      141       -4     
  Lines       18771    18149     -622     
==========================================
- Hits        11293    10496     -797     
- Misses       7478     7653     +175     

see 70 files with indirect coverage changes

[Fuseteam]

@mgallien are there are blockers left for this PR?

not sure how to test the upgrade path of an AppImage @Fuseteam do you have pointers to documentation about that ? despite having to work with AppImage, I am still lacking some good docs reference

i do not, but iirc https://github.com/AppImageCommunity/AppImageUpdate uses the zsync file to detect if there's an update and download it

[Fuseteam]

@mgallien DCO seems happy now, not sure about the rest

[Fuseteam]

Oh wait now i see the full error

[Fuseteam]

@mgallien now it should be fine