desktop icon indicating copy to clipboard operation
desktop copied to clipboard

UI enhancements: activities list

Open camilasan opened this issue 2 years ago • 7 comments

Bold is for issues to focus on

  • [ ] If there are multiple entries with exactly the same wording then show only the most recent one (they are displayed multiple times even though the have the same message, like "Synced readme.md")
  • [ ] Fetching activity only on open: Show an entry below "All synced" with icon MDI sync icon and text "Loading more activity"
  • [x] Clicking on any openable file should open the file itself in the default application and not the file viewer

camilasan avatar Apr 13 '22 11:04 camilasan

Regarding point 3 -- how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

claucambra avatar Apr 19 '22 10:04 claucambra

Regarding point 3 -- how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

@jancborchardt @nimishavijay ^^

camilasan avatar Jun 23 '22 12:06 camilasan

Ping? @jancborchardt @nimishavijay

claucambra avatar Jul 11 '22 11:07 claucambra

how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

Sounds good to me :) we could have an expand-more icon on the right, and when clicked it shows upto 5 entries with a "Show more" button, clicking on which would show 5 more and a "Show more", etc.

What do you think? cc @jancborchardt

nimishavijay avatar Jul 11 '22 11:07 nimishavijay

So activity entries should only group files which are in the same folder. And then, when one clicks on a grouped activity entry, we can open the containing folder.

What do you think?

jancborchardt avatar Jul 11 '22 15:07 jancborchardt

If there are multiple entries with exactly the same wording then show only the most recent one (they are displayed multiple times even though the have the same message, like "Synced readme.md")

#4736 should ensure that the client does not show duplicate activities, but this does not strictly resolve the behaviour your describe here as the server often provides multiple activities describing the same action at different points of time.

See for instance in this screenshot (same activity, i.e. the same file being changed by the same person, in red) from the activities app on the web interface:

Screenshot 2022-07-15 at 19 36 15

Since these are strictly separate activities served by the server I don't think we should be manually checking and filtering activities with repeated activities out @jancborchardt I would say this is behaviour that needs to be changed on the server side

claucambra avatar Jul 15 '22 17:07 claucambra

Another comment: AFAIK point number 2 is already the case, unless I am misinterpreting

claucambra avatar Jul 25 '22 10:07 claucambra

We can consider this completed :)

claucambra avatar Aug 16 '22 09:08 claucambra