Mark as single window app

[nicolasfella]

There can only be one instace of the client running

Mark it as such in the .desktop file

This allows desktop environments to adjust their UI accordingly

Signed-off-by: Nicolas Fella [email protected]

[mgallien]

@nicolasfella could you please rebase your PR on latest master such that we can merge it ?

[mgallien]

@nicolasfella can you have a look at the AppImage build error ? looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view :smile: )

[nicolasfella]

@nicolasfella can you have a look at the AppImage build error ? looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view smile )

SingleMainWindow is a very recent addition to the desktop file spec. It looks like the appimage tooling isn't up to date and doesn't account for version 1.5 of the spec

[mgallien]

@nicolasfella can you have a look at the AppImage build error ? looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view smile )

SingleMainWindow is a very recent addition to the desktop file spec. It looks like the appimage tooling isn't up to date and doesn't account for version 1.5 of the spec

will have a look at updating the AppImage tooling

[camilasan]

/rebase

[asensi]

Hello, I would suggest using SingleMainWindow=true instead of SingleMainWindow=True. That change avoids some errors like:

I try to package the latest unstable ktorrent based on this commit, but there is a desktop-file-validate error from the check stage:

$ desktop-file-validate org.kde.ktorrent.desktop org.kde.ktorrent.desktop: error: value "True" for boolean key "SingleMainWindow" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true" -- https://invent.kde.org/network/ktorrent/-/commit/95ec8bef250748f67b6cbb06abb944118b5aa9ac#note_488877

[codecov[bot]]

Codecov Report

Merging #4194 (326a1f6) into master (8a73a9a) will decrease coverage by 0.02%. Report is 1 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
- Coverage   60.26%   60.24%   -0.02%     
==========================================
  Files         145      145              
  Lines       18868    18868              
==========================================
- Hits        11370    11367       -3     
- Misses       7498     7501       +3     

see 1 file with indirect coverage changes