deck icon indicating copy to clipboard operation
deck copied to clipboard

Regression: No more link previews (NC 29, Deck 1.13.1) (Was: Links to other Cards do not show Card preview anymore)

Open MacLemon opened this issue 1 year ago • 4 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug Since upgrading to Nextcloud 29, cards in Deck that contain links to other cards, don't show a card preview anymore.

To Reproduce Steps to reproduce the behavior:

  1. Go to Deck
  2. any card
  3. Copy the URL from the browser's address bar
  4. navigate to any other card
  5. past the URL to the first card in the description field of the second card

Expected behavior A preview of the card should appear. Basically the same view of the card that is used in Deck itself to represent the cards. image

Actual behavior Only the link is shown, no more card preview in the description. image

Screenshots see above.

Notes This is a regression over Nextcloud 28 and earlier behavior where linked cards on the same instance would always show a convenient card preview allowing for efficient check of tags and completion status. Since Nextcloud 29, each link has to be clicked, loaded and checked manually, whereas before it was possible to quickly glance/scroll over to get the status of all linked cards. (This behavior was great for very efficient task dependency checks.)

Client details:

  • OS: macOS, but irrelevant
  • Browser Firefox 129.0, but irrelevant, happens in any browser
  • Version 129.0 (irrelevant)
  • Device: Desktop
Server details

Operating system:

Web server: nginx/1.27.0 (irrelevant to the issue)

Database: 10.8.8-MariaDB (irrelevant to the issue)

PHP version: 8.1.2-1ubuntu2.18 (irrelevant to the issue, happens with any other PHP 8.x version)

Nextcloud version: Nextcloud Hub 8 (29.0.4)

Where did you install Nextcloud from: Source

Signing status:

No errors have been found.

List of activated apps:

Enabled:
  - activity: 2.21.1
  - admin_audit: 1.19.0
  - analytics: 4.14.0
  - announcementcenter: 6.8.1
  - bookmarks: 14.2.4
  - bruteforcesettings: 2.9.0
  - calendar: 4.7.15
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - collectives: 2.13.0
  - comments: 1.19.0
  - contacts: 6.0.0
  - contactsinteraction: 1.10.0
  - dashboard: 7.9.0
  - dav: 1.30.1
  - deck: 1.13.1
  - external: 5.4.0
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.0
  - files_automatedtagging: 1.19.0
  - files_downloadlimit: 2.0.0
  - files_external: 1.21.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - firstrunwizard: 2.18.0
  - groupfolders: 17.0.1
  - impersonate: 1.16.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - maps: 1.4.0
  - nextcloud_announcements: 1.18.0
  - notes: 4.10.1
  - notifications: 2.17.0
  - notify_push: 0.7.0
  - oauth2: 1.17.0
  - password_policy: 1.19.0
  - phonetrack: 0.8.1
  - photos: 2.5.0
  - polls: 7.2.0
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - quota_warning: 1.19.0
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - richdocuments: 8.4.4
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - smb_test: 0.3.9
  - spreed: 19.0.7
  - support: 1.12.0
  - systemtags: 1.19.0
  - tasks: 0.16.0
  - terms_of_service: 2.5.0
  - text: 3.10.1
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_totp: 11.0.0-dev
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_status: 1.9.0
  - viewer: 2.3.0
  - weather_status: 1.9.0
  - workflowengine: 2.11.0

Nextcloud configuration:

<?php
$CONFIG = array (
  'passwordsalt' => '<REDACTED salt>',
  'secret' => '<REDACTED secret>',
  'trusted_domains' =>
  array (
    0 => '<REDACTED FQDN>',
    1 => '<REDACTED hostname>',
    2 => '<REDACTED IP Address>',
  ),
  'datadirectory' => '/data',
  'dbtype' => 'mysql',
  'version' => '29.0.4.1',
  'overwrite.cli.url' => 'https://<REDACTED FQDN>',
  'overwritehost' => '<REDACTED FQDN>',
  'overwriteprotocol' => 'https',
  'dbname' => 'nextcloud',
  'dbhost' => 'localhost',
  'dbport' => '',
  'dbtableprefix' => 'oc_',
  'mysql.utf8mb4' => true,
  'dbuser' => 'nextcloud',
  'dbpassword' => '<REDACTED db passwird>',
  'dbpersistent' => '',
  'installed' => true,
  'instanceid' => '<REDACTED instance ID>',
  'activity_expire_days' => 14,
  'allow_local_remote_servers' => true,
  'auth.bruteforce.protection.enabled' => true,
  'blacklisted_files' =>
  array (
    0 => '.htaccess',
    1 => 'Thumbs.db',
    2 => 'thumbs.db',
  ),
  'cron_log' => true,
  'enable_previews' => true,
  'enabledPreviewProviders' =>
  array (
    0 => 'OC\\Preview\\PNG',
    1 => 'OC\\Preview\\JPEG',
    2 => 'OC\\Preview\\GIF',
    3 => 'OC\\Preview\\BMP',
    4 => 'OC\\Preview\\XBitmap',
    5 => 'OC\\Preview\\Movie',
    6 => 'OC\\Preview\\PDF',
    7 => 'OC\\Preview\\MP3',
    8 => 'OC\\Preview\\TXT',
    9 => 'OC\\Preview\\MarkDown',
  ),
  'filesystem_check_changes' => 0,
  'filelocking.enabled' => 'true',
  'htaccess.RewriteBase' => '/',
  'integrity.check.disabled' => false,
  'knowledgebaseenabled' => false,
  'log_rotate_size' => '104857600',
  'logfile' => '/var/log/nextcloud/nextcloud.log',
  'loglevel' => 2,
  'logtimezone' => 'Europe/Vienna',
  'memcache.local' => '\\OC\\Memcache\\APCu',
  'memcache.locking' => '\\OC\\Memcache\\Redis',
  'overwriteprotocol' => 'https',
  'preview_max_x' => 1024,
  'preview_max_y' => 768,
  'preview_max_scale_factor' => 1,
  'profile.enabled' => false,
  'redis' =>
  array (
    'host' => '/var/run/redis/redis-server.sock',
    'port' => 0,
    'password' => '<REDACTED redis password>',
    'timeout' => 0.5,
    'dbindex' => 1,
  ),
  'quota_include_external_storage' => false,
  'share_folder' => '/<REDACTED foldername>',
  'twofactor_enforced' => 'false',
  'twofactor_enforced_groups' =>
  array (
  ),
  'twofactor_enforced_excluded_groups' =>
  array (
  ),
  'mail_smtpmode' => 'smtp',
  'mail_smtpsecure' => 'ssl',
  'mail_sendmailmode' => 'smtp',
  'mail_from_address' => '<REDACTED hostname>',
  'mail_domain' => '<REDACTED domain name>',
  'mail_smtpauthtype' => '<REDACTED AUTH type>',
  'mail_smtpauth' => 1,
  'mail_smtphost' => '<REDACTED MX FQDN>',
  'mail_smtpport' => '<REDACTED port>',
  'mail_smtpname' => '<REDACTED Email Address>',
  'mail_smtppassword' => '<REDACTED smtppassword>',
  'trusted_proxies' =>
  array (
    0 => '127.0.0.1',
    1 => '::1',
    2 => '<REDACTED Proxy IP Address>',
  ),
  'maintenance' => false,
  'trashbin_retention_obligation' => 'auto, 7',
  'versions_retention_obligation' => 'auto, 30',
  'maintenance_window_start' => 1,
  'simpleSignUpLink.shown' => false,
  'default_phone_region' => '<REDACTED region code>',
  'default_language' => '<REDACTED lang>',
  'default_locale' => '<REDACTED locale>',
  'default_timezone' => '<REDACTED TZ>',
  'skeletondirectory' => '',
  'preview_concurrency_new' => 2,
  'preview_concurrency_all' => 4,
);

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... No, only internal user accounts used.

Logs

Nextcloud log (data/nextcloud.log)

Doesn't log anything when opening the detail view of a card.#### Browser log

Insert your browser log here, this could for example include:

a) The javascript console log

Unknown pseudo-class or pseudo-element ‘-ms-clear’.  Ruleset ignored due to bad selector.

b) The network log

https://cloud.example.org/avatar/maclemon/64?v=2
Transferred: NS_BINDING_ABORTED

MacLemon avatar Aug 12 '24 15:08 MacLemon

Issue is still present in

  • Nextcloud 29.0.5
  • Deck 1.13.1

Addition to the general issue: This does not only affect Deck-Card-Previews, but all link previews. (Issue title adapted accordingly.)

MacLemon avatar Aug 22 '24 08:08 MacLemon

Issue still present in:

  • Nextcloud 29.0.7
  • Deck 1.13.2

MacLemon avatar Sep 25 '24 10:09 MacLemon

I'm unable to reproduce this. If you click on the link, to left a 3 dot menu bar should appear. It lets you toggle between the preview mode between Text only and Show link preview. Is it perhaps off?

joshtrichards avatar Oct 02 '24 14:10 joshtrichards

The ⠇ menu does not appear always, hence it's not possible to activate the preview for all links. (This was possible before and it was the default.)

The default has been changed from showing-link-previews to not showing them unless manually turned on. This causes support load by users being used to see a preview and being unable to turn it on.

I'm not aware of a way to change said default back to always show link previews. There is no setting for this in neither board details nor Deck settings.

MacLemon avatar Oct 09 '24 16:10 MacLemon

Is there any more info I can provide? (Asking because of the “Needs info” tag.)

Issue persists in

  • Nextcloud 30.0.2/Hub 9
  • Deck App 1.14.2

In addition when the ⠇ menu does exist, its shown in black dots on black background when the browser is set to dark-mode.

Is there a way to make “show link-previews” the default as it was via an occ command that I haven't yet discovered? (I'd consider this a viable workaround, even if a proper fix would require a user-clickable setting in Deck.)

MacLemon avatar Nov 28 '24 17:11 MacLemon

Thanks for taking the time to report this and sorry for the delayed response. This was an intentional change in text to make the generation of previews optional for users.

I can see that this is a change in behaviour that might be unexpected for some use cases but so far this seems the only report we have gotten. We will keep your feedback in consideration in future discussions regarding this feature.

juliusknorr avatar Jan 03 '25 14:01 juliusknorr