deck icon indicating copy to clipboard operation
deck copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Update TrelloJsonService.php

Open mulles opened this issue 9 months ago • 8 comments

Fixes the following issue: https://github.com/nextcloud/deck/issues/5136 By fixing the following error when running 'php occ deck:import --system=TrelloJson'

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:136

and

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:364

  • Resolves: https://github.com/nextcloud/deck/issues/5136
  • Target version: main

Summary

TODO

  • [ ] ...

Checklist

  • [x] Code is properly formatted
  • [x] Sign-off message is added to all commits
  • [x] Tests (unit, integration, api and/or acceptance) are included
  • [x] Documentation (manuals or wiki) has been updated or is not required

mulles avatar May 07 '24 18:05 mulles

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

Apfelwurm avatar May 08 '24 17:05 Apfelwurm

/backport to stable29

juliusknorr avatar May 09 '24 11:05 juliusknorr

/backport to stable28

juliusknorr avatar May 09 '24 11:05 juliusknorr

/backport to stable27

juliusknorr avatar May 09 '24 11:05 juliusknorr

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

I've just successfully imported a Trello-Board using TrelloApi after applying the proposed changes. Works fine. :-)

chkpnt avatar May 11 '24 18:05 chkpnt

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar May 22 '24 02:05 github-actions[bot]

Would it be possible to get an official release soon to make it more easier for the people currently migrating from Trello to Nextcloud Deck following the monetisation of Trello?

new2f7 avatar Jun 01 '24 06:06 new2f7

@mulles Integration tests failed. Could you please rebase your branch?

luka-nextcloud avatar Oct 08 '24 10:10 luka-nextcloud