deck icon indicating copy to clipboard operation
deck copied to clipboard

Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter

Open modir opened this issue 1 year ago • 1 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug I have Nextcloud 29 installed a week ago and my log keeps filled with this message:

Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /path/to/nextcloud/apps/deck/lib/Service/ConfigService.php#234

It doesn't look like a big problem but it would be nice if it is addressed soon so that it doesn't fill the logs. I guess I get this message because I am already on PHP 8.3 and you are testing with earlier versions.

modir avatar May 01 '24 09:05 modir

Just as an extra note, even just enabling the app will trigger this error, as well. However, using the mobile app and updating changes does not seem to trigger it.

Worth noting that albeit OP is on PHP 8.3, the instance I am getting the same error is on PHP 8.1.

daffydock avatar May 01 '24 15:05 daffydock

Fixed by https://github.com/nextcloud/deck/pull/5794 (yet to be released).

solracsf avatar May 16 '24 11:05 solracsf