deck icon indicating copy to clipboard operation
deck copied to clipboard

feat: add validators to check values in services

Open luka-nextcloud opened this issue 3 years ago • 2 comments

Signed-off-by: Luka Trovic [email protected]

  • Resolves: #
  • Target version: master

Summary

TODO

  • [ ] ...

Checklist

  • [ ] Code is properly formatted
  • [ ] Sign-off message is added to all commits
  • [ ] Tests (unit, integration, api and/or acceptance) are included
  • [ ] Documentation (manuals or wiki) has been updated or is not required

luka-nextcloud avatar Sep 13 '22 17:09 luka-nextcloud

Any breaking changes in here? I didn't see one at the first look, but just to make sure 😉

stefan-niedermann avatar Sep 13 '22 17:09 stefan-niedermann

@luka-nextcloud Indentation seems off quite a bit in some places. Maybe double check your editor settings to use tab indentation. php-cs-fixer should however be able to auto fix those with composer run cs:fix

juliusknorr avatar Sep 22 '22 10:09 juliusknorr

@juliushaertl Please check again.

luka-nextcloud avatar Sep 23 '22 16:09 luka-nextcloud

/backport to stable25

juliusknorr avatar Oct 31 '22 11:10 juliusknorr

/backport to stable24

juliusknorr avatar Oct 31 '22 11:10 juliusknorr

/backport to stable23

juliusknorr avatar Oct 31 '22 11:10 juliusknorr

The backport to stable24 failed. Please do this backport manually.

The backport to stable23 failed. Please do this backport manually.

  • stable23 https://github.com/nextcloud/deck/pull/4175
  • stable24 https://github.com/nextcloud/deck/pull/4176

juliusknorr avatar Oct 31 '22 12:10 juliusknorr