deck icon indicating copy to clipboard operation
deck copied to clipboard

Refactor board activites to filter by board id

Open juliusknorr opened this issue 6 years ago • 0 comments
trafficstars

The activity app onyl allows fetching by object_type and object_id

https://github.com/nextcloud/activity/blob/dee03c7f5ca2d201b5c204c1bdde4b15bb640258/lib/Controller/APIv2.php#L208

Currently all card activities are fetched and filtered by board in the frontend.

https://github.com/nextcloud/deck/blob/f3b5fd4030dd04985a87ec7cca8cd1fc488fb781/lib/Activity/ActivityManager.php#L61-L62

A possible way to improve this would be to also create an activity for the object_type board for all card actions.

https://github.com/nextcloud/deck/blob/f3b5fd4030dd04985a87ec7cca8cd1fc488fb781/lib/Activity/ActivityManager.php#L304

Probably also needs some adjustments on the parameters that get replaced: https://github.com/nextcloud/deck/blob/f18accd9c44fa82dee49e62ed3695f8b151000f8/lib/Activity/DeckProvider.php#L121


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

juliusknorr avatar Aug 23 '19 09:08 juliusknorr