dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Dashboard should not call code of the activity app

Open nickvergessen opened this issue 8 years ago • 0 comments

https://github.com/nextcloud/dashboard/blob/master/lib/Service/ActivityService.php#L29-L31

This is wrong and should not be done. Apps must not call each others code like this. What you want to do is make it possible for other apps to provide dashboard panels. Have a look at:

  1. The activity manager with settings/filters/providers
  2. The notification manager with notifiers/apps
  3. The settings manager with personal/admin sections/settings

We have enough examples how to avoid inter-app-dependencies, but this here is just bad...

nickvergessen avatar Jul 26 '17 09:07 nickvergessen