cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Add error handling for all responses in `AppNavi.vue`

Open seyfeb opened this issue 4 years ago • 4 comments

There are some axios calls in AppNavi.vue which don’t check the response.

We should add some code to check the response and handle any possible errors (this was shortly discussed in #497).

seyfeb avatar Jan 15 '21 16:01 seyfeb

Actually, I think they are already checked. The responses fall in the 2xx range; the catch statement handles other codes (compare the axios documentation)

seyfeb avatar Jan 22 '21 20:01 seyfeb

I was thinking more of a misconfigured server. If anything goes wrong, NC will most probably return the default page (dashbord it is for my instance currently). So a simple check with the string, if it is OK, might be a good idea.

christianlupus avatar Jan 24 '21 11:01 christianlupus

@seyfeb if you think this is a no-issue (maybe in the meantime), you can close this issue as well.

christianlupus avatar Feb 04 '21 16:02 christianlupus

See also #577

christianlupus avatar Oct 20 '21 13:10 christianlupus