cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Update RecipeView.vue

Open philiprenich opened this issue 1 year ago β€’ 3 comments

Fix grid layout causing large white space

  • Allow rows to be auto sized
  • Use gap instead of an extra column
  • Adjust row & column as necessary

Topic and Scope

These changes to the grid layout will remove the excess white space on the recipe view, especially for small screens.

Concerns/issues

Due to Vue's scoped styles, this should not affect anything else.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • [ ] I did check that the app can still be opened and does not throw any browser logs
    • CSS only change. But apologies regardless as I have not set up a dev env for Nextcloud yet.
  • [x] I created tests for newly added PHP code (check this if no PHP changes were made)
  • [x] I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • [x] I notified the matrix channel if I introduced an API change

philiprenich avatar Apr 08 '24 04:04 philiprenich

@seyfeb does this collide with your work currently?

christianlupus avatar Apr 16 '24 17:04 christianlupus

@seyfeb does this collide with your work currently?

Definitely, as I touched almost everything in the frontend. At least, in the RecipeView I moved things around a lot. However, it might take some weeks until my changes are finalized, so if you want to push out a new release with the updated style included, it would be okay, I guess.

seyfeb avatar Apr 16 '24 19:04 seyfeb

Test Results

β€‡β€ˆβ€‡12 filesβ€„β€ƒβ€‡β€ˆ584 suites   1m 32s :stopwatch: β€‡β€ˆ573 testsβ€ƒβ€‡β€ˆ573 :white_check_mark: 0 :zzz: 0 :x: 2β€ˆ292 runsβ€Šβ€ƒ2β€ˆ291 :white_check_mark: 1 :zzz: 0 :x:

Results for commit b3b4c085.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 01 '24 15:05 github-actions[bot]