cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Feat/507 add citation field

Open seyfeb opened this issue 2 years ago • 2 comments

Topic and Scope

Adds support for the citation property (https://schema.org/citation) to recipe editor and viewer.

Example with citation: "Peter Pan"

Screenshot 2023-12-23 at 18 10 20

Closes #507

Concerns/issues

Possible UI/UX option: Make citation text an anchor if URL property is set. This would make for a cleaner look (no URL is shown). Caveats: What if URL is set, but no citation field?

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • [x] I did check that the app can still be opened and does not throw any browser logs
  • [x] I created tests for newly added PHP code (check this if no PHP changes were made)
  • [x] I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • [x] I notified the matrix channel if I introduced an API change

seyfeb avatar Dec 23 '23 17:12 seyfeb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.07%. Comparing base (116d92f) to head (2a38427). Report is 617 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2023   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          92       92           
  Lines        2650     2650           
=======================================
  Hits         2122     2122           
  Misses        528      528           
Flag Coverage Δ
integration 21.43% <ø> (ø)
migration 5.69% <ø> (ø)
unittests 57.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 23 '23 17:12 codecov[bot]

Test Results

   12 files    572 suites   1m 30s :stopwatch:   552 tests   552 :white_check_mark: 0 :zzz: 0 :x: 2 208 runs  2 207 :white_check_mark: 1 :zzz: 0 :x:

Results for commit 2a384277.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 23 '23 17:12 github-actions[bot]