contacts icon indicating copy to clipboard operation
contacts copied to clipboard

fix(deps): Upgrade @nextcloud/vue to fix focus-trap compatibility

Open nfebe opened this issue 1 month ago • 5 comments

Upgrade @nextcloud/vue from ^8.27.0 to ^8.34.0 to resolve focus-trap library version mismatch with the guests app. The mismatch caused "_setPausedState is not a function" error when opening the guest invite dialog from the Teams member picker.

Without this the "Invite guest" modal does not work over the "Add team members" modal.

nfebe avatar Dec 04 '25 19:12 nfebe

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Dec 04 '25 19:12 codecov[bot]

@nfebe is it a problem that the tests are failing and who would be a good reviewer for this? @janepie will also give a review

DaphneMuller avatar Dec 08 '25 14:12 DaphneMuller

Hi @nfebe

This probably needs a transformation exclusion like in calendar.

https://github.com/nextcloud/calendar/blob/5f1e875a3d36291bbd394c628efdb0e0c97d8c88/package.json#L150

SebastianKrupinski avatar Dec 08 '25 14:12 SebastianKrupinski

@nfebe is it a problem that the tests are failing and who would be a good reviewer for this?

Yes, I made a fix but I will review the recently suggested workaround as well.

Should be done today.

nfebe avatar Dec 08 '25 15:12 nfebe

@nfebe is it a problem that the tests are failing and who would be a good reviewer for this?

Yes, I made a fix but I will review the recently suggested workaround as well.

Should be done today.

nfebe avatar Dec 08 '25 15:12 nfebe