contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Contact count includes disabled/inactive addressbooks

Open wunschadresse opened this issue 1 year ago • 5 comments

Describe the bug

Not necessarily a bug, but as user, I would expect a different behavior.

Steps to reproduce

  1. Go to contacts
  2. have several addressbooks shared with you (i did not test using owned addressbooks)
  3. check the count next to your all members/single contact groups
  4. disable one adressbook
  5. check the count again

Expected behavior

Count should change, based on the active addressbooks.

Actual behavior

Count includes inactive address books

Contact version

5.5.1

Operating system

Win10 + Firefox 122.0.1 (64-Bit)

PHP engine version

None

Web server

None

Database

None

Additional info

No response

wunschadresse avatar Feb 16 '24 08:02 wunschadresse

I can confirm this behaviour with own adressbooks. And I have addition to Expected/Actual behavior:

Expected behavior

Contact Birthdays of Contacts that are in disabled addressbooks are not shown in Calendar app.

Actual behavior

Birthdays of contacts from disabled addressbooks are shown in Calendar app.

Contact Version

7.1.0

roccostorm avatar May 14 '25 15:05 roccostorm

Hi,

This should now be fixed by https://github.com/nextcloud/contacts/pull/4442

I will work on the back port today, and it should be part of a release in the next couple weeks.

SebastianKrupinski avatar May 14 '25 15:05 SebastianKrupinski

Backports are in, they will be shipped some time next week.

Please let us know if this is still an issue after the update.

SebastianKrupinski avatar May 14 '25 16:05 SebastianKrupinski

I have run the update and the

Contact Version: 7.1.1

  • Contact Count for Groups is still wrong
  • Contact Birthdays from Disabled Addresbooks are still shown in the Calendar

roccostorm avatar May 22 '25 07:05 roccostorm

Contact Version 7.11 - same behavior as mentioned before.

MicKress avatar May 24 '25 11:05 MicKress

Hello, I just double checked the fix was released on 7.1.1. Can you please remove browser cache and reload the page. and let me know if the bug still persists

hamza221 avatar Jun 26 '25 15:06 hamza221

Accidental close still waiting for confirmation

hamza221 avatar Jun 26 '25 15:06 hamza221

As you can see in this screenshoots, the "All Contacts" counter is updated if an adressbook is disabled, but the counter for the groups is still wrong. Image Image

In addition, I have still two more problems:

  • brithdays from contacts of a diasabled adressbook are shown in calendar app
  • I have a adressbook that shows zero contacts since the last update, but when I sync it via caldav, it is not empty.

But this may be seperate problems not related to this ticket.

roccostorm avatar Jun 27 '25 08:06 roccostorm

As you can see in this screenshoots, the "All Contacts" counter is updated if an adressbook is disabled, but the counter for the groups is still wrong.

Just to make sure, when you refresh the page it gets updated right?

brithdays from contacts of a diasabled adressbook are shown in calendar app

I have a adressbook that shows zero contacts since the last update, but when I sync it via caldav, it is not empty.

Can you please open new issues for these

hamza221 avatar Jun 27 '25 09:06 hamza221

Yes. The "All Contacts" Counter is updated imediately, the contact groups only after reloading.

roccostorm avatar Jun 27 '25 10:06 roccostorm

I will close this issue as the bug in question is solved. I opened a new issue #4536 for the contact group count

hamza221 avatar Jun 27 '25 12:06 hamza221