contacts Moved users_picker profile custom picker to contacts

Moving the users_picker as it was planned with @DaphneMuller and @julien-nc.

But there is a conflict in NcSelect component ([Vue warn]: You may have an infinite update loop in a component render function.). It works with vue 2.7.14, but not with vue (2.6.14) in contacts, maybe @ChristophWurst can help with it and decide where do we want to move the profile picker.

Jun 27 '23 14:06 andrey18106

Weird thing: NcSelect works fine in other places in Contacts even with [email protected].

Also worth mentioning: The profile picker component works fine in https://github.com/nextcloud/users_picker and we can reproduce the problem there when downgrading vue to 2.6.14.

Jun 27 '23 15:06 julien-nc

Moving the users_picker as it was planned with @DaphneMuller and @julien-nc.

So what is the plan? Who will maintain that code once it's been moved into this repo?

Jun 27 '23 17:06 ChristophWurst

Codecov Report

Patch coverage has no change and project coverage change: -1.82% :warning:

Comparison is base (33060a4) 1.81% compared to head (5ca4d6c) 0.00%. Report is 167 commits behind head on main.

:exclamation: Current head 5ca4d6c differs from pull request most recent head 74f4deb. Consider uploading reports for the commit 74f4deb to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3487      +/-   ##
==========================================
- Coverage     1.81%   0.00%   -1.82%     
- Complexity     272     299      +27     
==========================================
  Files          113      27      -86     
  Lines         6126     903    -5223     
  Branches      1479       0    -1479     
==========================================
- Hits           111       0     -111     
+ Misses        5899     903    -4996     
+ Partials       116       0     -116

Files Changed	Coverage Δ
lib/AppInfo/Application.php	`0.00% <0.00%> (ø)`
lib/Listener/ProfilePickerReferenceListener.php	`0.00% <0.00%> (ø)`
lib/Reference/ProfilePickerReferenceProvider.php	`0.00% <0.00%> (ø)`

... and 88 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jun 30 '23 15:06 codecov[bot]

Moving the users_picker as it was planned with @DaphneMuller and @julien-nc.

So what is the plan? Who will maintain that code once it's been moved into this repo?

the contacts maintainers will maintain the code, but we are happy to give the team any code walk-throughs so everybody is comfortable with it.

Jul 04 '23 10:07 DaphneMuller

discussed with Christoph that this issue can be merged after the icon issue is resolved (https://github.com/nextcloud/contacts/pull/3487#discussion_r1253443738)

will check with @andrey18106

Sep 12 '23 08:09 DaphneMuller

Hi @ChristophWurst , is there any chance you or your team could take it from here?

Oct 25 '23 07:10 DaphneMuller

This isn't a light change, so I'll have to allocate resources for the feature.

Oct 25 '23 08:10 ChristophWurst

@andrey18106 I see the security problems have been fixed in your repo. Could you please update this branch? Cheers

Feb 08 '24 17:02 ChristophWurst

Maybe it's better to clarify if we actually want to proceed with this PR given the timeline this is already open?

Feb 14 '24 12:02 DaphneMuller