nextcloud
Recent contacts should not appear in search results
Describe the bug
If I search for a contact and it's also one of the recently used contacts, it appears twice in the results, creating confusion.
Steps to reproduce
- Search for a contact which is in the recently contacted
- See the contact which appears twice
Expected behavior
Only the original contact should appear.
Actual behavior
The original appears with its virtual recently contacted version.
Contact version
5.3.2
Operating system
Ubuntu Server
PHP engine version
PHP 8.1
Web server
Apache (supported)
Database
MySQL
Additional info
Nextcloud 26.0.2
I think there have been fixes to this with 27. did you already tried rhat version?
I think there have been fixes to this with 27. did you already tried rhat version?
Not yet.
@jancborchardt @marcoambrosini @nimishavijay for making a call on whether Recently contacted are to be treated special and excluded from search
@ChristophWurst can't we just filter the list before rendering and remove dupes?
Or can we filter only the "all contacts" list?
Recently contacted are part of All contacts. It is literally all contacts of all enabled address books you see there.
The duplication is tackled in https://github.com/nextcloud/server/issues/31606.
Well, depends.
If the issue is that you see duplicate results because of a real contact and the recently contacted entry, yes.
If the issues is that no Recently contacted should ever show as search result, even if you don't have that person as real contact, then no.
Ok I get it now, thanks. I think it could be handy to show deduplicated recently contacted people but I would add captions elements in the returned list to clearly differentiate between your contacts and people that you've recently contacted that are not in your contacts. Just like the conversation search in talk that displays the conversation you've joined first and then the conversations that you can join, and so forth.
Not related but we could have an "add to contacts" action on the recently contacted
Not related but we could have an "add to contacts" action on the recently contacted
We have that but it's called Clone contact
I think there have been fixes to this with 27. did you already tried rhat version?
The issue is still persitent in NC 27.1.1 with Contacts App 5.4.2
The original issue you describe @Jerome-Herbinet is not so much "Recent contacts should not appear in search results" but rather "Duplicate contacts should not appear.
Since the related issue @ChristophWurst mentioned is fixed as per https://github.com/nextcloud/server/issues/31606, I would say this issue can be closed.
By design, we do want recently contacted people to show up in search.
