contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Left sidebar: Badge counter doesn't use primary color

Open st3iny opened this issue 3 years ago • 4 comments

Describe the bug

The badge counters in the left sidebar don't use the primary color. They use the primary color in other apps (e.g. Mail).

Steps to reproduce

  1. Open the Contacts app.
  2. Observe left sidebar.

Expected behavior

The badge counter should use the primary color.

Actual behavior

They are gray.

image

Take a look at the Mail app for comparison:

image

Contact version

main

st3iny avatar Sep 21 '22 09:09 st3iny

cc @GretaD You already had an idea how to fix this easily.

st3iny avatar Sep 21 '22 10:09 st3iny

yes, do the same in contacts like we did on mail: https://github.com/nextcloud/mail/pull/7058

the appnavigationcounter is not used anymore

GretaD avatar Sep 21 '22 10:09 GretaD

appnavigationcounter should be marked for deprecation then

ChristophWurst avatar Sep 21 '22 10:09 ChristophWurst

appnavigationcounter should be marked for deprecation then

it is on vue: https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationCounter/NcAppNavigationCounter.vue

GretaD avatar Sep 21 '22 11:09 GretaD