contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Properly decode escaped principal urls

Open tintou opened this issue 3 years ago • 2 comments

Apply the same fix as in https://github.com/nextcloud/calendar/commit/8c294b12e16cf0fb9e4297eb35310d341ec30de3 to allow sharing with groups that contains spaces and escaped characters

Fixes #2411

tintou avatar Sep 20 '22 15:09 tintou

Codecov Report

Base: 31.65% // Head: 67.96% // Increases project coverage by +36.30% :tada:

Coverage data is based on head (5bed365) compared to base (d5cdb70). Patch has no changes to coverable lines.

:exclamation: Current head 5bed365 differs from pull request most recent head 4a08aa9. Consider uploading reports for the commit 4a08aa9 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2946       +/-   ##
=============================================
+ Coverage     31.65%   67.96%   +36.30%     
  Complexity      253      253               
=============================================
  Files           104       23       -81     
  Lines          1832      721     -1111     
  Branches        211        0      -211     
=============================================
- Hits            580      490       -90     
+ Misses         1141      231      -910     
+ Partials        111        0      -111     
Impacted Files Coverage Δ
...ppNavigation/Settings/SettingsAddressbookShare.vue
src/models/rfcProps.js
src/components/MembersList/MembersListItem.vue
src/router/index.js
src/components/AppNavigation/RootNavigation.vue
src/components/AdminSettings.vue
src/components/Properties/PropertyGroups.vue
src/components/ContactsList/ContactsListItem.vue
src/main.js
src/views/Processing/ImportView.vue
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 15:09 codecov[bot]

/backport to stable4.4

ChristophWurst avatar Sep 20 '22 16:09 ChristophWurst

/backport to stable5.0

ChristophWurst avatar Sep 29 '22 11:09 ChristophWurst

The backport to stable4.4 failed. Please do this backport manually.

@ChristophWurst Is the backport to stable4.4 still relevant? It would have to be done manually.

st3iny avatar Sep 29 '22 12:09 st3iny

If we want the fix for 24 and older, yes https://github.com/nextcloud/contacts/blob/stable5.0/appinfo/info.xml#L42.

ChristophWurst avatar Sep 29 '22 12:09 ChristophWurst

/backport to stable4.2

st3iny avatar Sep 29 '22 12:09 st3iny

If we want the fix for 24 and older, yes https://github.com/nextcloud/contacts/blob/stable5.0/appinfo/info.xml#L42.

Done

st3iny avatar Sep 29 '22 12:09 st3iny