contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Multiple merge delete

Open MrPompom opened this issue 3 years ago • 4 comments

commits to add features linked to :https://github.com/nextcloud/contacts/issues/70#issue-197512830 and https://github.com/nextcloud/contacts/issues/277#issue-248344665

How it works :

When the mouse is over a contact, the avatar changes to a checkbox. The checkbox can be checked, when only 1 checkbox is selected, the delete button appears, when it's 2 or more it's a menu with the delete and merge button.

image

Delete :

When the delete button is clicked, all the selected contacts are deleted image

Merge :

When the merge button is clicked, it will merge all the selected contacts into the first selected contact image

The value except uid, version, fn, prodid, gender, rev will be added into the first selected contact

The value who already exist and default value will not be added image

MrPompom avatar May 24 '22 10:05 MrPompom

Codecov Report

Base: 31.41% // Head: 67.96% // Increases project coverage by +36.54% :tada:

Coverage data is based on head (b6635b5) compared to base (68b15a3). Patch has no changes to coverable lines.

:exclamation: Current head b6635b5 differs from pull request most recent head e89d9a3. Consider uploading reports for the commit e89d9a3 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2756       +/-   ##
=============================================
+ Coverage     31.41%   67.96%   +36.54%     
  Complexity      253      253               
=============================================
  Files           110       23       -87     
  Lines          1862      721     -1141     
  Branches        217        0      -217     
=============================================
- Hits            585      490       -95     
+ Misses         1162      231      -931     
+ Partials        115        0      -115     
Impacted Files Coverage Δ
src/components/ContactsList.vue
src/components/ContactsList/ContactsListItem.vue
src/services/checks/invalidREV.js
src/mixins/PropertyMixin.js
src/components/Properties/PropertyGroups.vue
src/components/Properties/PropertyDateTime.vue
src/components/MembersList/MembersListItem.vue
src/router/index.js
src/models/rfcProps.js
src/utils/chartUtils.js
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 30 '22 15:05 codecov[bot]

I just rebased this. Hopefully I didn't break anything while doing so.

szaimen avatar Oct 11 '22 10:10 szaimen

@MrPompom please have a look at https://github.com/nextcloud/contacts/pull/2756#pullrequestreview-1144582880. Would that be something you could address? Cheers

ChristophWurst avatar Jan 17 '23 10:01 ChristophWurst

I really would like to have multi contact selection for batch deletion, that would be a very very welcome feature. Without the need of installing Thunderbird.

Ps. @MrPompom doesn't seem to be active anymore at all under GitHub. I think it's better to copy his changes and continue in another branch if needed.

melroy89 avatar Feb 16 '24 23:02 melroy89