contacts icon indicating copy to clipboard operation
contacts copied to clipboard

fix the rev test

Open MrPompom opened this issue 3 years ago • 4 comments

Signed-off-by: Bastien PROMPSY [email protected]

MrPompom avatar May 12 '22 10:05 MrPompom

@MrPompom could you please elaborate on the problem this fixes? For review and testing I would prefer to have some reproduction steps, either here or in a related bug report. Then we can check main and you branch to see if/how the problem is fixed :)

JuliaKirschenheuter avatar May 13 '22 07:05 JuliaKirschenheuter

This, commit is to correct a warning on the InvalidRev check.

Before this commit, when a contact is selected, a warning invalidateRev appear.

This commit is to stop this invalidateRev warning

MrPompom avatar May 18 '22 11:05 MrPompom

Codecov Report

Merging #2738 (e4d34ee) into main (53390f4) will not change coverage. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #2738   +/-   ##
=========================================
  Coverage     18.04%   18.04%           
  Complexity      247      247           
=========================================
  Files            97       97           
  Lines          3170     3170           
  Branches        439      439           
=========================================
  Hits            572      572           
  Misses         2405     2405           
  Partials        193      193           
Impacted Files Coverage Δ
src/services/checks/invalidREV.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53390f4...e4d34ee. Read the comment docs.

codecov[bot] avatar May 31 '22 17:05 codecov[bot]

I'm not able to reproduce the bug. Could you be a more specific about the steps needed to reproduce the bug?

st3iny avatar Jun 07 '22 07:06 st3iny

I'm closing due to lack of feedback from the author.

ChristophWurst avatar Dec 15 '22 15:12 ChristophWurst