Renaming a shared address book doesn't work

[nursoda]

Describe the bug

I want to rename an address book that was shared to my user (directly or via group) but cannot. Instead I get an "rename was unsuccessful" error popup.

To Reproduce Steps to reproduce the behavior:

1. as admin A create a user U
2. add U and A to G
3. impersonate U, go to contacts app
4. create address book 1 ; leave default address book ("Contacts" of U) (referred-to as 2 here)
5. share 1 and 2 to G (writable)
6. "logout" (back to A), go to contacts app
7. in contacts settings, try to rename 1 or 2

Expected behavior The renaming should be possible to have "local" address book names.

Actual behavior A toast message appears top right informing the user that the renaming was unsuccessful.

Server configuration

NC22 on NGINX/MariaDB/PHP8 on Arch, contacts 4.0.6

[miaulalala]

Hi nursoda, thanks for your report. I just tested this and you're right - a user cannot rename an address book that is shared with them. But IMHO that makes sense. What doesn't make sense is seeing the rename button on address books that are shared with a user.

Is this a feature you would be using quite regularly? Because I would prefer removing the "rename" feature for address books that are shared with a user, even if they are writable.

[nursoda]

Personally, I'd like to rename them since the Long names are inherited and displayed in other contexts, such as mobile devices e.g. using DAVx⁵ (and cannot be renamed there). But it's definitively a "nice to have".

So it's up to you / the "product owner" to decide whether renaming should be possible or be removed from the web UI.

[Bjo-Frei]

I found this issue because I will rename shared addressbooks. In the calendar app it's possible to rename the shared calendar. They saved the individual displayname in the properties of the user/Principal. It's possible to do this also for the contacts?