Implement Drag and Drop feature for adding contacts to group

[SteKoe]

This PR implements the requested feature in #564. I have also added some Docker-related files to allow running the app in a dockerized Nextcloud instance. I have added a section to the README.md file :)

https://user-images.githubusercontent.com/1809221/136859286-a73d3665-2b8c-48b1-bb09-e6aaee02db91.mp4

[ChristophWurst]

Awesome feature!

We'll review this soon.

Regarding the Dockerized dev setup, I would prefer to not have this in the app repo. After all there are hundres of Nextcloud apps and we can't maintain dev setup instructions and configuration everywhere. Are your instructions something that we could integrate into https://docs.nextcloud.com/server/stable/developer_manual/getting_started/devenv.html?

[SteKoe]

Hi @ChristophWurst,

thanks for your feedback :) I have removed the Docker part from readme as well as the codebase and will create a PR on nextcloud/documentation repo when I find some spare time!

Best, Stephan

[szaimen]

I just rebased this. Hopefully I didn't break anything while doing so.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 2.06%. Comparing base (57c246f) to head (3217649). Report is 2 commits behind head on main.

Files	Patch %	Lines
...c/components/AppNavigation/GroupNavigationItem.vue	0.00%	39 Missing :warning:
src/components/ContactsList/ContactsListItem.vue	0.00%	12 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #2466      +/-   ##
==========================================
- Coverage     2.44%   2.06%   -0.38%     
- Complexity       0     261     +261     
==========================================
  Files           90     114      +24     
  Lines         4541    5363     +822     
  Branches      1163    1165       +2     
==========================================
  Hits           111     111              
- Misses        4310    5132     +822     
  Partials       120     120              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ChristophWurst]

Almost

[ChristophWurst]

Hey @SteKoe!

Friendly ping on the requested changes above. Do you have the time needed to finish and get into a mereable state?

Cheers

[ChristophWurst]

@SteKoe would you have time to finish this PR? It's not mergeable as-is. See the feedback above.

[hamza221]

Rebased and Updated the Pr

[hamza221]

This does nothing for me - I can't drag & drop the contact to any contact group

for all contacts? because it doesn't work for SAB contacts by design

[hamza221]

Only thing that I don't like but it's not a big problem is that the Contacts group changes to a disabled input field instead of updating the text. Otoh it provides a nice visual feedback that the groups have changed so that's just me being prissy:

https://github.com/nextcloud/contacts/pull/3752 there's a PR to fix that already maybe it's time to get it merged

[welcome[bot]]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22