From Deck, all collectives' landing pages are named "Landing page"
Describe the bug When I search a collective to link it from a Deck card, it does not appear if I type its name. It appears that the landing page of any collective is searchable as "Landing page", which is confusing as it is not obvious and it is confusing if you have access to many collectives. Regarding pages created inside a collective, they are searchable thanks to their name.
To Reproduce Steps to reproduce the behavior:
- Go to 'Deck' and create a card
- Inside the description of the card, click on + or type / and select to search for a page from a Collective
- Type the name of the collective: nothing pops out. Type "Landing" and all landing pages are visible.
NB: I use a french version where it is labelled "Page d'atterrissage", I guess it is called "Landing page" in english.
Expected behavior It should be possible to search for the landing page of a collective thanks to the name of the collective.
Screenshots
Server details:
- Collectives app version: 3.1.2
- Deck app version: 1.15.3
- Nextcloud version: 31.0.8
- PHP Version: 8.3
- Database: MySQL
Client details:
- OS: Debian and Ubuntu
- Browser: Librewolf
- Browser version: 143.0.1-1
- Device: laptop and desktop
Thanks for your report @Coqorico - I was able to confirm this even in collectives itself using the smart picker to link to another collectives landing page.
In the end this boils down to the collectives-pages search provider not returning landing pages when searching for the collectives name.
https://github.com/nextcloud/collectives/blob/c77292ac285334dd23a081a65413f3d0d6b4c9b2/lib/Search/PageProvider.php#L70C37-L70C49 seems to be relavent.
However we might want to use the collective search provider instead. It's currently not included in the SearchablePageReferenceProvider.
I don't know how its results would need to be handled by the Reference Provider though.
Funny enough, I noticed that yesterday too. Could it be that the problem is new? I can't remember doing this successfully though (I mean searching for the acutal name of the landing page), but I was surprised that it does work like @Coqorico described and now I am wondering if I wouldn't have noticed this much earlier 🤷
But maybe it's also coincidence!