client_theming icon indicating copy to clipboard operation
client_theming copied to clipboard

New sync state icons

Open jancborchardt opened this issue 8 years ago • 59 comments

I worked on a new set of sync icons (also to fix #43). They are based on 16*16 grid, use our rounder style and don’t use the logo anymore (cause that’s very wide and caused the icon to be small). These can be used for both the tray icon as well as the sync state over the files themselves.

states-big Actual 16*16 size: states

For the monochrome icons, the icon in the circle will be cut out of the circle, hence be transparent. For the colored one, the icon in the circle will be white to work on both light and dark backgrounds, as well as on mobile where it can overlap image previews even more.

What do you think @rullzer @pfiff45 @AndyScherzinger @tobiasKaminsky @mario @marinofaggiana will this work on desktop and mobile too? cc @nextcloud/designers

Just one question: Do we really need all the states?

  • The one I never saw and would like to get rid of is the green »Download« icon. It should be the blue sync one if downloading, and the green checkmark if downloaded / synced. See also #10
  • Also, what’s the difference between the info-grey and warning-yellow icon? The info-state is really strange – either there is an issue you need to look at, or it’s not an issue.

jancborchardt avatar Aug 08 '17 11:08 jancborchardt

@jancborchardt Nice work! 👍 ...and yes this will work on Android while I need the source files though to create the overlay image work :)

AndyScherzinger avatar Aug 08 '17 12:08 AndyScherzinger

The one I never saw and would like to get rid of is the green »Download« icon. It should be the blue sync one if downloading, and the green checkmark if downloaded / synced. See also #10

:+1: get rid of the down arrow. The sync one should also be fine for the download state on mobile devices.

Also, what’s the difference between the info-grey and warning-yellow icon? The info-state is really strange – either there is an issue you need to look at, or it’s not an issue.

Yep - get rid if this "i".

MorrisJobke avatar Aug 08 '17 12:08 MorrisJobke

And this would also allow to not need to brand those icons anymore. Just use the default and the branded clients looks fine as well. 😉

MorrisJobke avatar Aug 08 '17 12:08 MorrisJobke

"i" could be "Someone shared X with you" in activites, or no?

enoch85 avatar Aug 08 '17 12:08 enoch85

get rid of the down arrow. The sync one should also be fine for the download state on mobile devices.

@MorrisJobke how do you distinguish between "downloaded" and "kept available offline" (as-in-constantly-kept-in-sync-with-the-server)?

AndyScherzinger avatar Aug 08 '17 12:08 AndyScherzinger

@MorrisJobke how do you distinguish between "downloaded" and "kept available offline" (as-in-constantly-kept-in-sync-with-the-server)?

The little star icon?

MorrisJobke avatar Aug 08 '17 12:08 MorrisJobke

The little star icon?

Right! Whoops.... ;)

AndyScherzinger avatar Aug 08 '17 13:08 AndyScherzinger

And this would also allow to not need to brand those icons anymore. Just use the default and the branded clients looks fine as well.

Exactly. One point of course is how to distinguish between Nextcloud and other apps like Dropbox, Google Drive etc. But that’s easy, since ours is the only simple non-branded one. :) Actually quite nice.

jancborchardt avatar Aug 08 '17 13:08 jancborchardt

Here’s the updated states with download icon and info icon removed, and Pause icon made grey (makes more sense than yellow cause it’s a chosen state): states-new

Anything else? What’s the exact difference between warning and error?

jancborchardt avatar Aug 08 '17 14:08 jancborchardt

Anything else? What’s the exact difference between warning and error?

warning: a file has conflicts but both states are synced error: internal server error for example

MorrisJobke avatar Aug 08 '17 16:08 MorrisJobke

Ok - last question:

The grey 3-dot icon, is that "connecting" or what? Cause when you are connecting, we could show the blue circular arrow. And when you are offline (but no local changes) show green checkmark - when offline with local changes show the yellow (!)

Or why do we need a separate icon for that?

jancborchardt avatar Aug 08 '17 16:08 jancborchardt

The grey 3-dot icon, is that "connecting" or what? Cause when you are connecting, we could show the blue circular arrow. And when you are offline (but no local changes) show green checkmark - when offline with local changes show the yellow (!)

This is also the icon if you have no folders in your sync list or when you start the app the first time, then there is the setup screen and this tray icon.

MorrisJobke avatar Aug 08 '17 17:08 MorrisJobke

instead of using a regular circle - that IMHO does not bring into mind nextcloud at all - why not use the side circles instead?

next

This seems more "nextcloud characteristic" (it does, however, bring a lot of other issues, such as the size of the icons it will have to contain within, for example)

maverick74 avatar Aug 10 '17 15:08 maverick74

@maverick74 yep, of course I tried this out too and as you said, the size of the icons within will be much too small. The icons are based on a 16*16px grid, and the thickness of lines is only 2px already. Reducing it would be too little.

jancborchardt avatar Aug 11 '17 14:08 jancborchardt

Since I wasn’t 100% happy with the »Connecting« icon (conflict with our 3-dots icon which stands for menu, and isn’t really identifiable as Nextcloud), I adjusted it to work better for a first-run experience: states-new-logo

I think this is the final version and I’ll prepare a pull request to replace the icons. Any last feedback @MorrisJobke @AndyScherzinger @rullzer @skjnldsv @juliushaertl @pixelipo anyone else? :)

jancborchardt avatar Aug 12 '17 16:08 jancborchardt

I'm ok with this! :)

skjnldsv avatar Aug 12 '17 16:08 skjnldsv

Well... with the Nextcloud Logo as connecting-icon you introduced the brand again. The advantage of the other icon was that it was unbranded and more easy to use for providers, ... :)

MariusBluem avatar Aug 12 '17 16:08 MariusBluem

Good point @MariusBluem

skjnldsv avatar Aug 12 '17 16:08 skjnldsv

Then let’s say for branded providers we can use the 3-dot-icon as the connecting one? @rullzer @jospoortvliet @MorrisJobke does that work? Maybe we can even adjust it according to the chosen icon, although that might be too much? cc @juliushaertl

If it’s too much of a hassle of course we can just go back to the 3-dot icon too. What do y’all think?

jancborchardt avatar Aug 12 '17 17:08 jancborchardt

:+1: fine by me :)

AndyScherzinger avatar Aug 13 '17 10:08 AndyScherzinger

Fine by both

MorrisJobke avatar Aug 13 '17 12:08 MorrisJobke

Pull request at https://github.com/nextcloud/client_theming/pull/200, please review :)

jancborchardt avatar Aug 15 '17 14:08 jancborchardt

(got pointed here from #201) But I have to throw s.th. in (even the change is "done") The change not also implies updated Icons (yes, with some unfitting properties/sizing, etc as discussed in #201), but also provide a clear change in recognizability - in a bad way... I'm not able to recognize it as the sync icon anymore neither to assiociate it with "nextcloud" or a "product" and perhaps others think/feel the same?

@jds2726 "minimalistic" doesn't mean to throw away any UX (not saying I'm a expert). Even a (sorry) loveless, boring cloud icon doesn't improve anything if you ask me. If any cloud service provider will update their Icon to a cloud icon, we'll end up in a hell of coloured cloud icons (wink Microsoft)

I think the icons before were far way meaningful even they were not perfect and had their own problems - especially the branding

so: thank you @jancborchardt for the efford and the change and to throw in s.th. to think about ;)

But honestly, I really hope anyone has the time and the skills to improve this "icon set" one more time. Unfortunately: as a typical dev, I'm not in ;/ I was just able to express what I "feel"

childnode avatar Nov 17 '17 08:11 childnode

@childnode yes, I agree that in theory the icons before were better, that's why I made them. :) However in practice they lead the important part of the icon – the indicator itself – to be way too small, because of the logo being quite wide and this very small when put in a square.

I will experiment with the state icons overflowing the logo or being outside of it.

jancborchardt avatar Nov 17 '17 08:11 jancborchardt

hi @jancborchardt , yeah that's why I said

… were not perfect and had their own problems - especially the branding yes, I read about the problems ... nothing to swear ..

to post s.th. productive: at least on (Mac)OS X the "schema" for tray icons seems to me:

  • (hard outline), unfilled for disabled state
  • light grayed for inactive
  • white (or sometimes animated) for active
  • colored in error mode, even on b&w theme

some related resources

  • https://developer.apple.com/library/content/documentation/General/Conceptual/ExtensibilityPG/Finder.html
  • https://developer.apple.com/macos/human-interface-guidelines/overview/visual-index/

windows, gnome, KDE .... perhaps s.o. else does know ;)

we should avoid conflicts with system icons:

  • https://developer.apple.com/macos/human-interface-guidelines/icons-and-images/system-icons/
  • windows, gnome, KDE .... perhaps does s.o. else know where to find the resources ;)

childnode avatar Nov 17 '17 15:11 childnode

To give this discussion a new drive I just created some new proposals. As I myself am using Ubuntu with the dark standard theme the icons are on a dark background but can of course be changed easily.

Version 1: combining the logo and the current state icons.

I changed the yellow slightly so it looks less mustardish. states-big 16px: states Here are the files separatedly: nextcloud-icons-new1.zip

Version 2: simple mono icons with nextcloud branding.

The inactive logos are both semi-transparent and the active logo simply shows the logo instead of being green and attention seeking. I'm not fully sure what cases the warning is for so it might make sense to make it red also for using it in more than one OS. The shapes are all combined, making the logo transparent and eases integration (Ubuntu paints every icon white making a white circle out of the logo of the current client). states-big 16px: states Here are the files separatedly: nextcloud-icons-new2.zip

Personally I'd prefer version 2 but the kind of version 1 had been proposed and integrates the icons we already had. Maybe this could be a solution to #201 and and update to #200

schokonsti avatar Jan 13 '18 21:01 schokonsti

Well my sugestion would be the old ones for the colored version: auswahl_20180114_09 21 09

And the new ones for the mono: auswahl_20180114_09 21 28

All the icons already exist and should be easy to activate

MegaV0lt avatar Jan 14 '18 08:01 MegaV0lt

@MegaV0lt you said so before. Using different icons for color and mono is not the best solution. My second approach would serve as mono and color at the same time and would integrate well in most environments.

schokonsti avatar Jan 14 '18 16:01 schokonsti

One option could also be to allow custom icon sets to be included additionally to the existing...

schokonsti avatar Jan 18 '18 12:01 schokonsti

Hey everyone!

Since 16px icons seems like the hardest design task, I concentrated on that. If I get +1 from two or more people, I will make versions for all statuses.

Suggestions for colored: state-ok-smallercircle state-error-test-circlesmaller svg

Suggestions for monochrome: state-ok-smallercircle-monochrome state-error-smallercircle-monochrome

Comments: I feel like in @schokonsti 's version 1 the circles block too much of the nextcloud logo, so I made them smaller for the color version. For the monochrome version, we have too many circles going on already, so I just took the symbol (e.g. checkmark) and made the stroke a little wider (to 1,2px) and adjusted the position so it looks in balance.

Also, do we really need that many statuses? I feel it's a little confusing for the end user. As a user, I would expect three statuses: "Everything is great!" / "I am doing something, but things are great!" / "There is a problem!" .. with more information in the tooltip. Should I open a separate bug report to discuss this?

alexanderdd avatar Jan 19 '18 22:01 alexanderdd