circles icon indicating copy to clipboard operation
circles copied to clipboard

Change fill to white to match other icons.

Open rexbron opened this issue 2 years ago • 3 comments

Fixes #703

rexbron avatar Mar 15 '22 21:03 rexbron

The dark icon would still be needed, so maybe you can put it as circles-dark.svg and make sure that it is used in the places where the current one was used before:

lib/Notification/Notifier.php 150: $iconPath = $this->urlGenerator->imagePath(Application::APP_ID, 'circles.svg');

lib/Activity/Filter.php 54: $this->url->imagePath(Application::APP_ID, 'circles.svg')

lib/UnifiedSearch/UnifiedSearchProvider.php 163: $iconPath = $this->urlGenerator->imagePath(Application::APP_ID, 'circles.svg');

lib/Model/ShareWrapper.php 688: $urlGenerator->imagePath(Application::APP_ID, 'circles.svg')

juliushaertl avatar Mar 17 '22 09:03 juliushaertl

@juliushaertl Hi!

A separate icon for a dark theme is not required; the dark theme expects a pure white filled icon which it then styles:

image

image

This behavior is consistent with other 1st party apps in Nextcloud.

rexbron avatar Mar 17 '22 12:03 rexbron

It is not about the dark theme but other places where the icon is used like notifications or activity. There a dark icon variant would still be required.

juliushaertl avatar Mar 17 '22 15:03 juliushaertl

Done in another PR

Altahrim avatar Mar 14 '24 15:03 Altahrim