circles
circles copied to clipboard
Multiple fixes and add Group Backend support
NOTE: This big pull request will be eventually split in multiple pull requests...
- Add
group_backend
option to mirroring the circle as a group (automatically suffixed byCircle
) You can customize prefix and suffix with thegroup_backend_name_prefix
andgroup_backend_name_suffix
options The main goal is to have better integrations with Nextcloud applications and clients. (fix https://github.com/nextcloud/circles/issues/363) You should also hide these mirrored circles in Nextcloud applications and clients, because their equivalent group will be used instead, via theallow_listed_circles
option set to0
- When the
group_backend
option is enabled, store the mirrored group id in thegroup_id
column of thecircles_circles
table, useful when the circle's name is updated - Add option
allow_listed_circles
To show (1
, default) or hide (0
) circles in shared list, disabling this option is very useful when thegroup_backend
option is enabled - Exclude
personal
andsecret
circles from Group backend, if thegroup_backend
option is enabled
- When the
- Enhance
onSettingsChange
event to get old setting values (includingname
anddescription
attributes). - Add
allow_adding_any_group_members
option to allow (1
, default) or not adding group members from any users. When value is set to0
it's not possible anymore to add contacts as circle members forprivate
andpublic
circle types, and it's only possible for groups where the current user is a member or for global administrators. Because they can't be group members, useful when thegroup_backend
option is enabled. There is already theaccounts_only
option but it applied for any types of circles... (fix https://github.com/nextcloud/circles/issues/128) - You can now add members in
personal
circles whenskip_invitation_to_closed_circles
option is enabled (fix https://github.com/nextcloud/circles/issues/382 and https://github.com/nextcloud/circles/issues/360) - Fix Parsing error in activities when user request to join a circle (see https://github.com/nextcloud/circles/issues/243)
- Fix CSS
- Fix translations
- Fix adding group with member limit
-1
or0
(fix https://github.com/nextcloud/circles/issues/342)
Hi @daita,
Can you tell me if I need to split this big pull request in one pull request per commit, please?
Have a good day, Tortue Torche
Hello,
Thanks for this huge commit, but I would prefer a list of small PR instead ! (also, some of those are already fixed ;p)
Regards,
Hi @daita,
Thanks for this huge commit, but I would prefer a list of small PR instead ! (also, some of those are already fixed ;p)
It's done, here my pull requests: #390, #391, #392, #393, #394, #395, #396, #397, #398, #399, #400 and #401!
NB: You should merge them in the ascendant order, otherwise some issues might appears...
Have a good day, Tortue Torche
Closing since this PR was subsequently handled through split up PRs: https://github.com/nextcloud/circles/pull/384#issuecomment-611456041