fix(deps): update dependency @nextcloud/dialogs to v7 (main)
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| @nextcloud/dialogs | ^6.4.1 -> ^7.1.0 |
Release Notes
nextcloud-libraries/nextcloud-dialogs (@​nextcloud/dialogs)
v7.1.0
Enhancements
- feat(FilePicker): Improve pick and navigation logic to match user expectation by @​artonge in #​2033
Fixed
- fix: compress translations in assets by @​susnux in #​2044
Changes
- Updates for project Nextcloud dialogs library by @​transifex-integration[bot] in #​2045
- chore(deps): Update browserslist by @​artonge in #​2047
v7.0.1
Fixed
Changed
v7.0.0
Notes
This package now builds on top of @nextcloud/vue version 9 using Vue 3.
While this package uses Vue 3 it is also possible to use it within a Vue 2 project,
in this case the Vue dependency will not be shared as the dependency was moved from a peer dependency to a plain dependency.
This also means that if you are using Vue 2 you have to ensure you do not use bundler
configurations that enforce resolving Vue to the same version as this will fail now,
instead let the bundler choose the matching Vue version.
For example if using Webpack this will no longer work in Vue 2 apps:
resolve: {
alias: {
vue$: path.resolve('./node_modules/vue'),
},
}
For Vue 3 apps nothing changed, meaning the app and this library will share the same Vue dependency as long as the versions are compatible.
Breaking
- This package now uses Vue 3 internally.
- The deprecated FilePicker component export was removed to allow using this library in Vue 2 and Vue 3 apps.
- The deprecated
Dialog.hidemethod was removed, instead await the returned promise and wait for the user interaction. - The deprecated
Dialog.setHTMLmethod was removed. If you need custom HTML content useNcDialogfrom@nextcloud/vue. - The
spawnDialoghelper method was removed, instead use the function provided by@nextcloud/vue
- import { spawnDialog } from '@​nextcloud/dialogs'
+ import { spawnDialog } from '@​nextcloud/vue/functions/dialog'
Added
- feat: add guest auth prompt #​1760 (backportbot)
- feat(ConflictPicker): move conflict picker dialog from
@nextcloud/upload#​1971 (susnux) - feat(dialogs): allow to quickly show a dialog #​1986 (susnux)
Fixed
- fix(FilePickerBuilder): correctly return array / plain value depending on multiselect #​1775 (susnux)
- fix: display guest name validity #​1836 (skjnldsv)
- fix: return nodes array from smartpicker #​1879 (grnd-alt)
- fix(PublicAuthPrompt): change default notice if identified #​1880 (backportbot[bot])
- style(toast): adjust colors for Nextcloud 32 #​1912 (Antreesy)
- fix(guestName): limit length to 64 characters #​1915 (max-nextcloud)
- fix(FilePicker): make move primary and copy secondary #​1933 (susnux)
- fix: allow dismiss the undo toast #​1944 (luka-nextcloud)
Changed
- chore: update to ESLint v9 and apply new rules #​1753 (susnux)
- Updates for project Nextcloud dialogs library #​1757 (transifex-integration)
- chore: move from
dev:watchback towatch#​1758 (skjnldsv) - Updates for project Nextcloud dialogs library #​1776 (transifex-integration)
- refactor: adjust code to comply with code style (again) #​1774 (susnux)
- chore!: remove
spawnDialogin favor of version from@nextcloud/vue#​1783 (susnux) - refactor: do not use Node internals but @​nextcloud/paths package #​1752 (susnux)
- Updates for project Nextcloud dialogs library by @​transifex-integration[bot]
- chore(deps): @​nextcloud family + various upgrades #​1905 (skjnldsv)
- chore: fix node version for dependabot #​1960 (susnux)
- chore(dialogs)!: remove deprecated
setHTMLmethod #​1985 (susnux)
Configuration
📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
Cannot find module '@nextcloud/dialogs' from 'src/store/calendars.js'
Ahh, the usual jest not being compatible with ESM dependencies. I guess we have to move to vitest here too.
Cannot find module '@nextcloud/dialogs' from 'src/store/calendars.js'
Ahh, the usual jest not being compatible with ESM dependencies. I guess we have to move to vitest here too.
I had the same thought a couple of weeks ago
@SebastianKrupinski Here you go: https://github.com/nextcloud/calendar/pull/7614
Module /home/runner/work/calendar/calendar/node_modules/emoji-mart-vue-fast/src/index.js:1 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "emoji-mart-vue-fast" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.
We need patch-package here too (or mock aggressively) to patch type: "module" into their package.json. Something like I did in Mail for some packages.
Module /home/runner/work/calendar/calendar/node_modules/emoji-mart-vue-fast/src/index.js:1 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "emoji-mart-vue-fast" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.
We need patch-package here too (or mock aggressively) to patch
type: "module"into theirpackage.json. Something like I did in Mail for some packages.
I think the package-lock is out of sync, I can't npm ci on local dev
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:loudspeaker: Thoughts on this report? Let us know!
Tested everything seems to be working correctly