calendar icon indicating copy to clipboard operation
calendar copied to clipboard

fix(deps): update dependency @nextcloud/dialogs to v7 (main)

Open renovate[bot] opened this issue 3 months ago • 5 comments

This PR contains the following updates:

Package Change Age Confidence
@nextcloud/dialogs ^6.4.1 -> ^7.1.0 age confidence

Release Notes

nextcloud-libraries/nextcloud-dialogs (@​nextcloud/dialogs)

v7.1.0

Compare Source

Enhancements
Fixed
Changes

v7.0.1

Compare Source

Fixed
Changed

v7.0.0

Compare Source

Notes

This package now builds on top of @nextcloud/vue version 9 using Vue 3. While this package uses Vue 3 it is also possible to use it within a Vue 2 project, in this case the Vue dependency will not be shared as the dependency was moved from a peer dependency to a plain dependency. This also means that if you are using Vue 2 you have to ensure you do not use bundler configurations that enforce resolving Vue to the same version as this will fail now, instead let the bundler choose the matching Vue version.

For example if using Webpack this will no longer work in Vue 2 apps:

  resolve: {
		alias: {
			vue$: path.resolve('./node_modules/vue'),
		},
  }

For Vue 3 apps nothing changed, meaning the app and this library will share the same Vue dependency as long as the versions are compatible.

Breaking
  • This package now uses Vue 3 internally.
  • The deprecated FilePicker component export was removed to allow using this library in Vue 2 and Vue 3 apps.
  • The deprecated Dialog.hide method was removed, instead await the returned promise and wait for the user interaction.
  • The deprecated Dialog.setHTML method was removed. If you need custom HTML content use NcDialog from @nextcloud/vue.
  • The spawnDialog helper method was removed, instead use the function provided by @nextcloud/vue
- import { spawnDialog } from '@​nextcloud/dialogs'
+ import { spawnDialog } from '@​nextcloud/vue/functions/dialog'
Added
Fixed
Changed

Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Oct 15 '25 00:10 renovate[bot]

Cannot find module '@nextcloud/dialogs' from 'src/store/calendars.js'

Ahh, the usual jest not being compatible with ESM dependencies. I guess we have to move to vitest here too.

st3iny avatar Oct 21 '25 12:10 st3iny

Cannot find module '@nextcloud/dialogs' from 'src/store/calendars.js'

Ahh, the usual jest not being compatible with ESM dependencies. I guess we have to move to vitest here too.

I had the same thought a couple of weeks ago

SebastianKrupinski avatar Oct 21 '25 15:10 SebastianKrupinski

@SebastianKrupinski Here you go: https://github.com/nextcloud/calendar/pull/7614

st3iny avatar Oct 22 '25 08:10 st3iny

Module /home/runner/work/calendar/calendar/node_modules/emoji-mart-vue-fast/src/index.js:1 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "emoji-mart-vue-fast" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.

We need patch-package here too (or mock aggressively) to patch type: "module" into their package.json. Something like I did in Mail for some packages.

st3iny avatar Oct 22 '25 13:10 st3iny

Module /home/runner/work/calendar/calendar/node_modules/emoji-mart-vue-fast/src/index.js:1 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "emoji-mart-vue-fast" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.

We need patch-package here too (or mock aggressively) to patch type: "module" into their package.json. Something like I did in Mail for some packages.

I think the package-lock is out of sync, I can't npm ci on local dev

SebastianKrupinski avatar Oct 22 '25 13:10 SebastianKrupinski

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Dec 17 '25 15:12 codecov[bot]

Tested everything seems to be working correctly

SebastianKrupinski avatar Dec 19 '25 17:12 SebastianKrupinski