calendar icon indicating copy to clipboard operation
calendar copied to clipboard

feat: move simple editor actions to the bottom

Open st3iny opened this issue 3 months ago • 3 comments

Partially addresses https://github.com/nextcloud/calendar/pull/5906#pullrequestreview-1986633149

Move the simple editor actions menu to the bottom. This looks a lot cleaner, IMO. As requested by our designers.

Screenshots

Creating a new event

Screenshot_20250925_124357

Viewing my own event

Screenshot_20250925_124613

Viewing an invitation

Screenshot_20250925_124418

st3iny avatar Sep 25 '25 10:09 st3iny

Codecov Report

:x: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 13.56%. Comparing base (f189e36) to head (753491d). :warning: Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
src/views/EditSimple.vue 0.00% 41 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7491   +/-   ##
=======================================
  Coverage   13.56%   13.56%           
=======================================
  Files         218      218           
  Lines       11329    11327    -2     
  Branches     2710     2708    -2     
=======================================
  Hits         1537     1537           
+ Misses       9432     9430    -2     
  Partials      360      360           
Flag Coverage Δ
javascript 13.56% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 25 '25 10:09 codecov[bot]

@st3iny my only comment would be to cluster all the buttons at the bottom right.

3 dot menu - More Details - Edit

But its not a blocker

SebastianKrupinski avatar Sep 25 '25 11:09 SebastianKrupinski

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Oct 24 '25 02:10 github-actions[bot]