calendar icon indicating copy to clipboard operation
calendar copied to clipboard

chore: update composer to php 8.4 max

Open SebastianKrupinski opened this issue 6 months ago • 6 comments

  • Updated composer to php 8.4 max

SebastianKrupinski avatar Jun 20 '25 14:06 SebastianKrupinski

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.92%. Comparing base (ae81c17) to head (5817628). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7051   +/-   ##
=========================================
  Coverage     22.92%   22.92%           
  Complexity      478      478           
=========================================
  Files           251      251           
  Lines         12294    12294           
  Branches       2369     2382   +13     
=========================================
  Hits           2818     2818           
  Misses         9128     9128           
  Partials        348      348           
Flag Coverage Δ
javascript 14.56% <ø> (ø)
php 59.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 20 '25 14:06 codecov[bot]

Looks like a bunch of the test will need to be fixed for php 8.4

SebastianKrupinski avatar Jun 20 '25 15:06 SebastianKrupinski

It looks like you accidentally updated phpunit hence the failing unit tests.

Error: Call to undefined method PHPUnit\Framework\MockObject\Builder\InvocationMocker::withConsecutive()

Please revert the changes in the psalm and phpunit vendor-bins.

Yeah, composer did that automatically on me. It's better now.

SebastianKrupinski avatar Jun 20 '25 19:06 SebastianKrupinski

I'm not a fan of bundling manual dependency updates if not really required. We already have renovate to bump dependencies.

Is there a reason why we have to bump the minimum version of phpunit.

Without enforcing ^9 for phpunit "composer test" would not run.

image

Also any other dependencies that got bumped where a result of just bumping the coding standard with composer (granted maybe I didn't do it correctly lol)

SebastianKrupinski avatar Jun 20 '25 22:06 SebastianKrupinski

That is probably related to accidentally bumping phpunit. Manually updating composer dependencies is error prone unfortunately.

I moved the cs-fixer related changes to the renovate PR here: https://github.com/nextcloud/calendar/pull/7052

For this PR it makes sense to only keep the PHP version bump:

Updated composer to php 8.4 max

st3iny avatar Jun 21 '25 07:06 st3iny

Updated composer to php 8.4 max

Okay, I removed all the other changes

SebastianKrupinski avatar Jun 21 '25 14:06 SebastianKrupinski