feat: allow inviting contact groups
Fixes https://github.com/nextcloud/calendar/issues/167
To Do
- [ ] Duplicate Members - create a single attendee and add the duplicate group ids to the
MEMEBRproperty - [ ] Does it actually send invitation emails
- [ ] use
nc:groupname@groupinstead ofmailto:prefix?
Codecov Report
Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.
Project coverage is 23.44%. Comparing base (
f77d285) to head (7f70db9). Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6285 +/- ##
============================================
+ Coverage 23.33% 23.44% +0.11%
- Complexity 453 472 +19
============================================
Files 248 249 +1
Lines 11777 11888 +111
Branches 2245 2282 +37
============================================
+ Hits 2748 2787 +39
- Misses 8705 8774 +69
- Partials 324 327 +3
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | 14.87% <0.00%> (-0.09%) |
:arrow_down: |
| php | 59.47% <ΓΈ> (+0.17%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey,
Found an issue, I am selecting a Group with 2 members "Group B"
But after selecting the "Group B" it only shows one attendee and says there is only one member in the group.
Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?
Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?
Good point! User 1 is not in Group B, but Contact 1 and User 1 do have the same email address. I will test again.
Changing the participation status here doesn't actually change anything. Initially, I assumed that it would change the status for everyone in the group, but Editable John keeps his previous status.
Maybe we can remove this group participation status selector?
@st3iny Did you test emails being sent out while reviewing? I don't have a mail server setup so I don't know how to do that myself π .
Also, maybe you or @SebastianKrupinski could you please do me a favor and fix the merge conflict in lib/Controller/ContactController.php, there's quite a lot of stuff going on there and I don't want to mess it up
@st3iny Did you test emails being sent out while reviewing? I don't have a mail server setup so I don't know how to do that myself π .
Also, maybe you or @SebastianKrupinski could you please do me a favor and fix the merge conflict in
lib/Controller/ContactController.php, there's quite a lot of stuff going on there and I don't want to mess it up
Done
π