calendar icon indicating copy to clipboard operation
calendar copied to clipboard

feat: allow inviting contact groups

Open miaulalala opened this issue 1 year ago β€’ 1 comments

Fixes https://github.com/nextcloud/calendar/issues/167

To Do

  • [ ] Duplicate Members - create a single attendee and add the duplicate group ids to the MEMEBR property
  • [ ] Does it actually send invitation emails
  • [ ] use nc:groupname@group instead of mailto: prefix?

miaulalala avatar Aug 22 '24 15:08 miaulalala

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 23.44%. Comparing base (f77d285) to head (7f70db9). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% 23 Missing :warning:
src/store/calendarObjectInstance.js 0.00% 8 Missing and 4 partials :warning:
src/components/Editor/Invitees/InviteesList.vue 0.00% 9 Missing :warning:
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6285      +/-   ##
============================================
+ Coverage     23.33%   23.44%   +0.11%     
- Complexity      453      472      +19     
============================================
  Files           248      249       +1     
  Lines         11777    11888     +111     
  Branches       2245     2282      +37     
============================================
+ Hits           2748     2787      +39     
- Misses         8705     8774      +69     
- Partials        324      327       +3     
Flag Coverage Ξ”
javascript 14.87% <0.00%> (-0.09%) :arrow_down:
php 59.47% <ΓΈ> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 15:08 codecov[bot]

Hey,

Found an issue, I am selecting a Group with 2 members "Group B"

Screenshot 2024-11-12 200218

But after selecting the "Group B" it only shows one attendee and says there is only one member in the group.

Screenshot 2024-11-12 200247

SebastianKrupinski avatar Nov 13 '24 01:11 SebastianKrupinski

Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?

st3iny avatar Nov 14 '24 11:11 st3iny

Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?

Good point! User 1 is not in Group B, but Contact 1 and User 1 do have the same email address. I will test again.

SebastianKrupinski avatar Nov 14 '24 12:11 SebastianKrupinski

image

Changing the participation status here doesn't actually change anything. Initially, I assumed that it would change the status for everyone in the group, but Editable John keeps his previous status.

Maybe we can remove this group participation status selector?

GVodyanov avatar Nov 18 '24 18:11 GVodyanov

@st3iny Did you test emails being sent out while reviewing? I don't have a mail server setup so I don't know how to do that myself πŸ˜….

Also, maybe you or @SebastianKrupinski could you please do me a favor and fix the merge conflict in lib/Controller/ContactController.php, there's quite a lot of stuff going on there and I don't want to mess it up

GVodyanov avatar Nov 21 '24 18:11 GVodyanov

@st3iny Did you test emails being sent out while reviewing? I don't have a mail server setup so I don't know how to do that myself πŸ˜….

Also, maybe you or @SebastianKrupinski could you please do me a favor and fix the merge conflict in lib/Controller/ContactController.php, there's quite a lot of stuff going on there and I don't want to mess it up

Done

SebastianKrupinski avatar Nov 26 '24 15:11 SebastianKrupinski

πŸ‘€

SebastianKrupinski avatar Dec 05 '24 19:12 SebastianKrupinski