Event updates via mail only sent when date/time changes

[monochromec]

Steps to reproduce

1. Create an event in a group calendar with attendees mail addresses
2. Update event description

Expected behavior

Mail notification should have been sent to participants

Actual behaviour

Notification is only sent when changing date / time of the event and not when changing, for example, the description of the event.

Calendar app version

3.4.2

CalDAV-clients used

TB 102.1.2

Browser

N/A

Client operating system

OSX 12.4

Server operating system

Bullseye

Web server

Apache

Database engine version

PostgreSQL

PHP engine version

PHP 7.4

Nextcloud version

24.0.4

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - bruteforcesettings: 2.4.0
  - calendar: 3.4.2
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contactsinteraction: 1.5.0
  - dashboard: 7.4.0
  - dav: 1.22.0
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - firstrunwizard: 2.13.0
  - groupfolders: 12.0.1
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - nextcloud_announcements: 1.13.0
  - notifications: 2.12.0
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - polls: 3.7.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - recommendations: 1.3.0
  - richdocuments: 6.1.1
  - richdocumentscode: 22.5.301
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - support: 1.7.0
  - survey_client: 1.12.0
  - systemtags: 1.14.0
  - tasks: 0.14.4
  - text: 3.5.1
  - theming: 1.15.0
  - twofactor_backupcodes: 1.13.0
  - updatenotification: 1.14.0
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - files_texteditor: 2.14.0
  - spreed: 13.0.7
  - user_ldap

Nextcloud configuration

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "linuxinlaws.eu"
        ],
        "versions_retention_obligation": "3650, auto",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "24.0.4.1",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 1.5,
            "dbindex": 0
        },
        "loglevel": "0",
        "cron_log": true,
        "log_rotate_size": false,
        "maintenance": false,
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "theme": "",
        "app_install_overwrite": [
            "ldap_contacts_backend",
            "files_texteditor"
        ],
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

Web server error log

N/A

Log file

N/A

Browser log

No response

Additional info

Is the above intended behaviour?

More info can be provided - please detail requirements.

[ChristophWurst]

This could be seen as a sub task of https://github.com/nextcloud/calendar/issues/3919

[tcitworld]

This is https://github.com/nextcloud/calendar/issues/848#issuecomment-437855170 (which we could reopen instead)

[miaulalala]

This relies on a significant change being detected.

The detection happens inside the iTip\Broker class and is Sabre code (parseEventForOrganizer). Sabre strictly uses the definitions from the RFC to enforce a significant change update.

It might be possible to increase the sequence number - I'm not 100% but that might force Sabre to detect a significant change and regenrate the notification emails.

[flortsch]

https://github.com/nextcloud/3rdparty/blob/master/sabre/vobject/lib/ITip/Broker.php#L69 should be extended by the properties SUMMARY, LOCATION and DESCRIPTION, as mentioned in related issues like #848. My question is, is it allowed to patch libraries in the 3rdparty repo and later try to upstream those patches, or is it not possible? I don't know how libraries in the 3rdparty repository are handled in Nextcloud. But if it's allowed to provide patches for them, I could create a PR.